From owner-svn-src-all@FreeBSD.ORG Fri May 22 14:32:01 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A2418106564A; Fri, 22 May 2009 14:32:01 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 0ADBC8FC15; Fri, 22 May 2009 14:32:00 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAANUFkqDaFvK/2dsb2JhbADTFYQLBQ X-IronPort-AV: E=Sophos;i="4.41,233,1241409600"; d="scan'208";a="34167800" Received: from fraser.cs.uoguelph.ca ([131.104.91.202]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 22 May 2009 10:31:59 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by fraser.cs.uoguelph.ca (Postfix) with ESMTP id 930A9109C28B; Fri, 22 May 2009 10:31:59 -0400 (EDT) X-Virus-Scanned: amavisd-new at fraser.cs.uoguelph.ca Received: from fraser.cs.uoguelph.ca ([127.0.0.1]) by localhost (fraser.cs.uoguelph.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S+EY+D0AO1R7; Fri, 22 May 2009 10:31:59 -0400 (EDT) Received: from muncher.cs.uoguelph.ca (muncher.cs.uoguelph.ca [131.104.91.102]) by fraser.cs.uoguelph.ca (Postfix) with ESMTP id 11A22109C257; Fri, 22 May 2009 10:31:59 -0400 (EDT) Received: from localhost (rmacklem@localhost) by muncher.cs.uoguelph.ca (8.11.7p3+Sun/8.11.6) with ESMTP id n4MEWhZ01719; Fri, 22 May 2009 10:32:44 -0400 (EDT) X-Authentication-Warning: muncher.cs.uoguelph.ca: rmacklem owned process doing -bs Date: Fri, 22 May 2009 10:32:43 -0400 (EDT) From: Rick Macklem X-X-Sender: rmacklem@muncher.cs.uoguelph.ca To: =?utf-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= In-Reply-To: <86r5yhzaso.fsf@ds4.des.no> Message-ID: References: <200905201858.n4KIw7Fc040619@svn.freebsd.org> <86r5yhzaso.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-559023410-851401618-1243002763=:105" Cc: svn-src-head@FreeBSD.org, Rick Macklem , svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r192463 - head/sys/fs/nfsserver X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2009 14:32:02 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---559023410-851401618-1243002763=:105 Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Fri, 22 May 2009, Dag-Erling Sm=C3=B8rgrav wrote: > Rick Macklem writes: >> Log: >> Although it should never happen, all the nfsv4 server can do >> when it runs out of clientids is reboot. I had replaced cpu_reboot() >> with printf(), since cpu_reboot() doesn't exist for sparc64. >> This change replaces the printf() with panic(), so the reboot >> would occur for this highly unlikely occurrence. > > Regardless of how improbable this is, wouldn't it be better (and > simpler) to just log an error message and deny further mount requests? > Well, it this really is an issue I can just take the check for the wraparound out and let it continue on. Why? Because the likelyhood of a clientid issued 4billion time ago (many many years aka centuries, in practice) being for a client that still exists and hasn't rebooted or re-acquired a more recent clientid is essentialy 0 as well. In case you haven't done the calculation, 4billion seconds is 136 years. Since I cannot image a server seeing anything close to 1 new clientid/sec over an extended period (there could be a burst just after booting), the wraparound will take centuries to happen (maybe highly unlikely wasn't a strong enough term). Just don't worry about it, rick ---559023410-851401618-1243002763=:105--