From owner-p4-projects@FreeBSD.ORG  Tue Jul  7 12:56:30 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 279E01065710; Tue,  7 Jul 2009 12:56:30 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D42DB1065716
	for <perforce@FreeBSD.org>; Tue,  7 Jul 2009 12:56:29 +0000 (UTC)
	(envelope-from zhaoshuai@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id C1CE18FC23
	for <perforce@FreeBSD.org>; Tue,  7 Jul 2009 12:56:29 +0000 (UTC)
	(envelope-from zhaoshuai@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n67CuTGe052999
	for <perforce@FreeBSD.org>; Tue, 7 Jul 2009 12:56:29 GMT
	(envelope-from zhaoshuai@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n67CuTKe052997
	for perforce@freebsd.org; Tue, 7 Jul 2009 12:56:29 GMT
	(envelope-from zhaoshuai@FreeBSD.org)
Date: Tue, 7 Jul 2009 12:56:29 GMT
Message-Id: <200907071256.n67CuTKe052997@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	zhaoshuai@FreeBSD.org using -f
From: Zhao Shuai <zhaoshuai@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 165748 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jul 2009 12:56:31 -0000

http://perforce.freebsd.org/chv.cgi?CH=165748

Change 165748 by zhaoshuai@zhaoshuai on 2009/07/07 12:55:30

	comment on pipe_stat()

Affected files ...

.. //depot/projects/soc2009/fifo/sys/fs/fifofs/fifo_vnops.c#19 edit
.. //depot/projects/soc2009/fifo/sys/kern/sys_pipe.c#17 edit

Differences ...

==== //depot/projects/soc2009/fifo/sys/fs/fifofs/fifo_vnops.c#19 (text+ko) ====

@@ -613,6 +613,7 @@
 	error = pipe_stat(fip->fi_rpipe, sb, cred, td);
 	if (error)
 		return (error);
+	/* pipe_stat zeros all fields of *ub, following assignment should be done after it */
 	sb->st_uid = fp->f_cred->cr_uid;
 	sb->st_gid = fp->f_cred->cr_gid;
 	return (0);

==== //depot/projects/soc2009/fifo/sys/kern/sys_pipe.c#17 (text+ko) ====

@@ -194,6 +194,7 @@
 	error = pipe_stat(pipe, ub, active_cred, td);
 	if (error)
 		return (error);
+	/* pipe_stat zeros all fields of *ub, following assignment should be done after it */
 	ub->st_uid = fp->f_cred->cr_uid;
 	ub->st_gid = fp->f_cred->cr_gid;
 	return (0);