From owner-freebsd-current@FreeBSD.ORG Mon Nov 11 21:32:09 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id F05C2A64 for ; Mon, 11 Nov 2013 21:32:09 +0000 (UTC) (envelope-from nwhitehorn@freebsd.org) Received: from mail.icecube.wisc.edu (trout.icecube.wisc.edu [128.104.255.119]) by mx1.freebsd.org (Postfix) with ESMTP id AC4A02948 for ; Mon, 11 Nov 2013 21:32:09 +0000 (UTC) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.icecube.wisc.edu (Postfix) with ESMTP id AD9AA58388 for ; Mon, 11 Nov 2013 15:32:08 -0600 (CST) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from mail.icecube.wisc.edu ([127.0.0.1]) by localhost (trout.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id CQGv-Jd7plvO for ; Mon, 11 Nov 2013 15:32:08 -0600 (CST) Received: from terminus.icecube.wisc.edu (terminus.icecube.wisc.edu [172.16.223.97]) by mail.icecube.wisc.edu (Postfix) with ESMTP id 746A658385 for ; Mon, 11 Nov 2013 15:32:08 -0600 (CST) Message-ID: <52814CD8.5020708@freebsd.org> Date: Mon, 11 Nov 2013 15:32:08 -0600 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: freebsd-current@freebsd.org Subject: Re: Default MBR boot "manager" References: <33391A36-2E7A-473B-87E0-88BDE1AC97D1@fisglobal.com> In-Reply-To: <33391A36-2E7A-473B-87E0-88BDE1AC97D1@fisglobal.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Nov 2013 21:32:10 -0000 On 11/11/13 15:19, Teske, Devin wrote: > Topic: Lenovo Laptops and bsdinstall zfsboot with MBR layout... > > Should we do the quick patch to change the default > from /boot/boot0 to /boot/mbr: > > Index: zfsboot > =================================================================== > --- zfsboot (revision 258016) > +++ zfsboot (working copy) > @@ -764,7 +764,7 @@ zfs_create_diskpart() > # > f_eval_catch $funcname gpart "$GPART_CREATE" mbr \$disk || > return $FAILURE > - f_eval_catch $funcname gpart "$GPART_BOOTCODE" /boot/boot0 \ > + f_eval_catch $funcname gpart "$GPART_BOOTCODE" /boot/mbr \ > \$disk || return $FAILURE > > # > > That would fix things for Lenovo laptops for the next > release until I finish up the bootcode selection menu. > I'd like to take my time in making sure Allan and I design > a worthy bootcode selection menu. This patch looks good (I don't remember why it was boot0 in the first place). I think gpart automatically installs something like /boot/mbr by default, so I'd be interested to know if making the diff purely negative still works. On another note, I think we should move away from a selector. Right now, we have three kinds of boot code: 1. ZFS boot code 2. UFS boot code 3. boot0 Unifying 1 and 2 would help a lot -- I don't know of any reason we need both except for tradition. #3 is probably best done as a post-install config step ("Install FreeBSD boot manager" or something), which also means it works for UFS systems. -Nathan