From owner-svn-src-all@FreeBSD.ORG Tue Oct 21 10:07:48 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8EF6B1065674 for ; Tue, 21 Oct 2008 10:07:48 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.169]) by mx1.freebsd.org (Postfix) with ESMTP id 1AFCE8FC16 for ; Tue, 21 Oct 2008 10:07:47 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by ug-out-1314.google.com with SMTP id m2so842764uge.39 for ; Tue, 21 Oct 2008 03:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=cclCd4P48GpdVHCzpPpPP2bObfwbMEXHu9wqMIQSVn8=; b=CNnR2ztZIoGYeZSek4VXNPHRj2sFBMnhlz0OLWgqIqjtdIEEuWUbXMnUr8VuO7Y33T vElihQJnXb+hGO9Z64IjRsl5dqW8QJPhDgyLSC+8EQeD8tErxp/3SXNVHWq18zMjwzZt k4onDtBzKoRQhZ6WYZVznWN1s9lap7tNmpD9U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=fM6yBm76+W2Zy2joB+mlUjmTwM2QNYyfs7TWWrrJHxnwFwIqg6cbM+sNF2HETlNCxx JWoE+LaZGU1pFs+AT0IPQDV3qf8i1+u1AKzMdXsPhFD4k/qefApq95tcoweIu46RJpNA 8PU/F2auwOK1qKBJv1Xk9KswDZQN+YThjsox4= Received: by 10.103.40.5 with SMTP id s5mr4351338muj.133.1224583666074; Tue, 21 Oct 2008 03:07:46 -0700 (PDT) Received: by 10.103.239.14 with HTTP; Tue, 21 Oct 2008 03:07:45 -0700 (PDT) Message-ID: <3bbf2fe10810210307t664cc8a2s62606f03427286f3@mail.gmail.com> Date: Tue, 21 Oct 2008 12:07:45 +0200 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Jung-uk Kim" In-Reply-To: <200810210431.m9L4V7Pb088978@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200810210431.m9L4V7Pb088978@svn.freebsd.org> X-Google-Sender-Auth: ebde5b4826b26e4d Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184108 - head/sys/i386/i386 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Oct 2008 10:07:48 -0000 2008/10/21, Jung-uk Kim : > Author: jkim > Date: Tue Oct 21 04:31:07 2008 > New Revision: 184108 > URL: http://svn.freebsd.org/changeset/base/184108 > > Log: > Fix 'kern.timeconter.invariant_tsc' tunable and back out a redundant hack. > Somehow incomplete version was committed. :-( > > Modified: > head/sys/i386/i386/tsc.c > > Modified: head/sys/i386/i386/tsc.c > ============================================================================== > --- head/sys/i386/i386/tsc.c Tue Oct 21 03:18:02 2008 (r184107) > +++ head/sys/i386/i386/tsc.c Tue Oct 21 04:31:07 2008 (r184108) > @@ -53,7 +53,8 @@ u_int tsc_present; > static eventhandler_tag tsc_levels_tag, tsc_pre_tag, tsc_post_tag; > > SYSCTL_INT(_kern_timecounter, OID_AUTO, invariant_tsc, CTLFLAG_RDTUN, > - &tsc_is_invariant, 0, "Indicates the TSC is P-state invariant"); > + &tsc_is_invariant, 0, "Indicates whether the TSC is P-state invariant"); > +TUNABLE_INT("kern.timecounter.invariant_tsc", &tsc_is_invariant); > > #ifdef SMP > static int smp_tsc; > @@ -111,9 +112,8 @@ init_TSC(void) > set_cputicker(rdtsc, tsc_freq, 1); > > /* Register to find out about changes in CPU frequency. */ > - if (!tsc_is_invariant) > - tsc_pre_tag = EVENTHANDLER_REGISTER(cpufreq_pre_change, > - tsc_freq_changing, NULL, EVENTHANDLER_PRI_FIRST); > + tsc_pre_tag = EVENTHANDLER_REGISTER(cpufreq_pre_change, > + tsc_freq_changing, NULL, EVENTHANDLER_PRI_FIRST); > tsc_post_tag = EVENTHANDLER_REGISTER(cpufreq_post_change, > tsc_freq_changed, NULL, EVENTHANDLER_PRI_FIRST); > tsc_levels_tag = EVENTHANDLER_REGISTER(cpufreq_levels_changed, > Something we could do with this is adding a "quirk" table of TSC arch dependant known to be working (based on cpu_model and such) and use that table in order to replace tsc_smp. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein