From owner-svn-src-head@freebsd.org Mon Oct 16 18:53:01 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1289AE42002; Mon, 16 Oct 2017 18:53:01 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1D1E3682FA; Mon, 16 Oct 2017 18:52:59 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 9f344e4b; Mon, 16 Oct 2017 20:46:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=ldh/AplNGB70R3BLfyv7gRVRBGM=; b=P0srOSChbySnspLg5fkBfbnSmmYy aF0HamLfr1kZ7tcCY9O5YFHqITYdnlNO43Y2t8Tjrut/DHKvs7TUE6Ks6etuI8Rj d0xDJ/nOXcgY/wQIlR7KugX4dIQBDGd/wXDI3Nw0ZpFGDmu0N7eIvhGF+A6AN32U DHxJMtePkS5oAy0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=qJNf2gZXxU7tLG0OynrF3YWYjSZqtsFZXHv5gV/tksiVoExMv6+qtxs6 K0k+DYUuWyfBRGnrR4dKb7G0cFrxsGzrm9mb01zA3bmiY0uG059gt21WPvvFZ1Gk zZeqW4R+dfAKQOvnmlZGUI5Y4KdQ1CPTpVZckEBfkEfQzJDPn04= Received: from knuckles.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 7b4768dc TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Mon, 16 Oct 2017 20:46:16 +0200 (CEST) Date: Mon, 16 Oct 2017 20:46:13 +0200 From: Emmanuel Vadot To: Toomas Soome Cc: Andrew Turner , Warner Losh , eric@meatspace.com, src-committers , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Warner Losh Subject: Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader Message-Id: <20171016204613.3c9ea3e30cdb8dadf0b6fe9d@bidouilliste.com> In-Reply-To: References: <201710160359.v9G3xCCi087576@repo.freebsd.org> <3BED6A0F-689C-4B89-A2AA-6990FB473539@fubar.geek.nz> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; amd64-portbld-freebsd12.0) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 18:53:01 -0000 On Mon, 16 Oct 2017 20:08:19 +0300 Toomas Soome wrote: >=20 > The arm (uboot) has a bit different approach on block device(s), see efip= art_hdinfo_add_filepath() in efipart.c; the code needs to check for MEDIA_F= ILEPATH_DP, I think. >=20 > rgds, > toomas I'm pretty sure that qemu doesn't use u-boot but EDK2 directly. >=20 > > On 16 Oct 2017, at 19:07, Andrew Turner wrote: > >=20 > > Correct, it is aarch64. It runs a similar qemu command, however I also = see it under the ARM Foundation model so it seems to not be simulator speci= fic. > >=20 > > Andrew > >=20 > >> On 16 Oct 2017, at 16:56, Warner Losh > wrote: > >>=20 > >> So this is on aarch64? Is this running a standardish qemu setup as doc= umented on https://wiki.freebsd.org/arm64/QEMU ? Or are there tricks that we need to cope with... > >>=20 > >> If we can't get good resoltuion on this today, I plan on backing out t= he entire change. > >>=20 > >> Warner > >>=20 > >> On Mon, Oct 16, 2017 at 9:38 AM, Andrew Turner > wrote: > >> I have a local Jenkins setup that builds images & tries to run under v= arious simulators. The final image is built with mkimg. I?m running it unde= r qemu. > >>=20 > >> Andrew > >>=20 > >>> On 16 Oct 2017, at 13:19, Warner Losh > wrote: > >>>=20 > >>> I'll take a look, but I've also ccd Eric so he can figure out what we= nt wrong with is code in your environment. What env is That? > >>>=20 > >>> Warnee > >>>=20 > >>> On Oct 16, 2017 3:26 AM, "Andrew Turner" > wrote: > >>>=20 > >>> > On 16 Oct 2017, at 04:59, Warner Losh > wrote: > >>> > > >>> > Author: imp > >>> > Date: Mon Oct 16 03:59:11 2017 > >>> > New Revision: 324646 > >>> > URL: https://svnweb.freebsd.org/changeset/base/324646 > >>> > > >>> > Log: > >>> > Unify boot1 with loader > >>> > > >>> > Refactor boot1 to use the same I/O code as /boot/loader uses. Refa= ctor > >>> > to use the common efi_main.c. > >>> > > >>> > Submitted by: Eric McCorkle > >>> > Differential Revision: https://reviews.freebsd.org/D10447 > >>> > > >>> > Added: > >>> > head/sys/boot/efi/libefi/efi_main.c (contents, props changed) > >>> > - copied, changed from r324645, head/sys/boot/efi/loader/efi_ma= in.c > >>> > Deleted: > >>> > head/sys/boot/efi/boot1/boot_module.h > >>> > head/sys/boot/efi/boot1/ufs_module.c > >>> > head/sys/boot/efi/boot1/zfs_module.c > >>> > head/sys/boot/efi/loader/efi_main.c > >>> > Modified: > >>> > head/sys/boot/efi/boot1/Makefile > >>> > head/sys/boot/efi/boot1/boot1.c > >>> > head/sys/boot/efi/libefi/Makefile > >>> > head/sys/boot/efi/loader/Makefile > >>>=20 > >>> Hello Warner, > >>>=20 > >>> After this change I?m getting the following panic on various test VMs. > >>>=20 > >>> Andrew > >>>=20 > >>> >> FreeBSD EFI boot block > >>>=20 > >>> Loader path: /boot/loader.efi > >>>=20 > >>> Load Path: \EFI\BOOT\BOOTAA64.EFI > >>> Load Device: VenHw(837DCA9E-E874-4D82-B29A-23FE0E23D1E2,003C000A00= 000000)/HD(1,GPT,DD40E9C6-B247-11E7-AA0A-15EFE1BBB7CF,0x3,0x640) > >>> panic: Couldn't trim device path > >>> --> Press a key on the console to reboot <-- > >>>=20 > >>=20 > >>=20 > >=20 >=20 --=20 Emmanuel Vadot