Date: Wed, 21 Nov 2018 11:21:15 -0500 From: Charlie Li <ml@vishwin.info> To: Ben Widawsky <bwidawsk@freebsd.org> Cc: Jung-uk Kim <jkim@FreeBSD.org>, acpi@FreeBSD.org, current@freebsd.org, John Baldwin <jhb@freebsd.org> Subject: Re: ACPI Error: No handler for Region [ECOR] Message-ID: <5e26200c-f1c8-0076-eaa7-d019279e2b30@vishwin.info> In-Reply-To: <20181120193608.d4hjcogjybfbvght@smtp.freebsd.org> References: <bbdfac5c-ff65-9c8b-ccd0-3760c6d52e04@vishwin.info> <5f954581-26ab-b890-9cfd-a14598c7e9ba@FreeBSD.org> <20181120192855.lqppolymrzo2ynqk@smtp.freebsd.org> <20181120193608.d4hjcogjybfbvght@smtp.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EpRFbj0XIMd8bIjVI41GoduDsQk3zu048 Content-Type: multipart/mixed; boundary="vswG1MfKS3tvutydE76PNyGdNXHFobVJp"; protected-headers="v1" From: Charlie Li <ml@vishwin.info> To: Ben Widawsky <bwidawsk@freebsd.org> Cc: Jung-uk Kim <jkim@FreeBSD.org>, acpi@FreeBSD.org, current@freebsd.org, John Baldwin <jhb@freebsd.org> Message-ID: <5e26200c-f1c8-0076-eaa7-d019279e2b30@vishwin.info> Subject: Re: ACPI Error: No handler for Region [ECOR] References: <bbdfac5c-ff65-9c8b-ccd0-3760c6d52e04@vishwin.info> <5f954581-26ab-b890-9cfd-a14598c7e9ba@FreeBSD.org> <20181120192855.lqppolymrzo2ynqk@smtp.freebsd.org> <20181120193608.d4hjcogjybfbvght@smtp.freebsd.org> In-Reply-To: <20181120193608.d4hjcogjybfbvght@smtp.freebsd.org> --vswG1MfKS3tvutydE76PNyGdNXHFobVJp Content-Type: multipart/mixed; boundary="------------E4BFB7ADC262514C3DC80169" Content-Language: en-GB-large This is a multi-part message in MIME format. --------------E4BFB7ADC262514C3DC80169 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 20/11/2018 14:37, Ben Widawsky wrote: > On 18-11-20 11:28:56, Ben Widawsky wrote: >> On 18-11-20 14:09:08, Jung-uk Kim wrote: >>> On 18. 11. 20., Charlie Li wrote: >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [E= COR] >>>> (0xfffff80003662300) [EmbeddedControl] (20181031/evregion-288) >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl >>>> (ID=3D3) has no handler (20181031/exfldio-428) >>>> Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution >>>> failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-67= 7) >>>> >>> I am pretty sure r340644 caused the regression. >>> >>> https://svnweb.freebsd.org/changeset/base/340644 >>> >>> Jung-uk Kim >> >> Seems like a good bet. Could you please add the full dmesg as well as = an ACPI >> dump and the output of `sysctl dev.acpi_ec.` Thanks. The full dmesg is flooded. sysctl dev.acpi_ec: dev.acpi_ec.0.%parent: acpi0 dev.acpi_ec.0.%pnpinfo: _HID=3DPNP0C09 _UID=3D0 dev.acpi_ec.0.%location: handle=3D\_SB_.PCI0.LPC_.EC__ dev.acpi_ec.0.%driver: acpi_ec dev.acpi_ec.0.%desc: Embedded Controller: GPE 0x25, ECDT dev.acpi_ec.%parent: >=20 > Just for a quick eyeball, this looks suspicious. You could also try thi= s: >=20 I had to remove another line due to -Wunused-variable. In any case, the log spam continues unabated and battery status querying continues to fail= =2E Going to try backing out r340644 in my tree. --=20 Charlie Li Can't think of a witty .sigline today=E2=80=A6 (This email address is for mailing list use only; replace local-part with vishwin for off-list communication) --------------E4BFB7ADC262514C3DC80169 Content-Type: text/x-patch; name="r340644-fail.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="r340644-fail.patch" diff -r 531cf2dab058 sys/dev/acpica/acpi_ec.c --- a/sys/dev/acpica/acpi_ec.c Mon Nov 19 17:31:36 2018 -0500 +++ b/sys/dev/acpica/acpi_ec.c Wed Nov 21 10:52:58 2018 -0500 @@ -338,7 +338,6 @@ ACPI_HANDLE h; ACPI_OBJECT *obj; ACPI_STATUS status; - device_t peer; char desc[64]; int ecdt; int ret; @@ -422,6 +421,7 @@ /* Store the values we got from the namespace for attach. */ acpi_set_private(dev, params); =20 +#if 0 /* * Check for a duplicate probe. This can happen when a probe via ECD= T * succeeded already. If this is a duplicate, disable this device. @@ -431,6 +431,7 @@ ret =3D 0; else device_disable(dev); +#endif =20 if (buf.Pointer) AcpiOsFree(buf.Pointer); --------------E4BFB7ADC262514C3DC80169-- --vswG1MfKS3tvutydE76PNyGdNXHFobVJp-- --EpRFbj0XIMd8bIjVI41GoduDsQk3zu048 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE/3/Cqr5a+41PbEb+jnB43vIDq2wFAlv1hgAACgkQjnB43vID q2zIVBAAkMy6XDb7QRWa/mo+0h+Zhh30Tqms/HOPASPAoWePSgtDn/bXJXsZBwlk 7eS6DbrCjyfS+YYEBd3WXYrPcJNQg5aSO8L4EygYbvpIeI8jgLyWGZVBJqlgjbQw 2FBts5UYSsfNIgGTBW0UVjCmg1WCmcFEmR+xTliNPM2PoUtnFABxZ42NMQFKlh4h nOXd849TROVzT1q7T5JsHpt+XsfiKOqR7k+KWrLOrgxtItM2+o4ks9hs+wQutT52 BczLsm8sCXNXqO6Ja0tVbb8omuOnQcDtGfnQDyRLCRts55fmY3ho7ylfEnWGNa7i nVEoS1OUTg9CcBTYJJMmSz1OkMPTIR4HB0pH453U7eHxr/zGXHBPuetJ7RV9YoNr CBqr6fK5N1Z1V+lkexQTaOpV7ZD+ivAE+yFpI/ID07LiBnGI2o+OY+/FfBXJavcy RQihSbkRdEbIp1ddTvca/EWU53DRc59VjBJjaXRtAgaOwmOTLck+iz3p4zfmz8uM 0rM0XYX+fwqUEBfyZFO70tEmQghTauZwe2/1Z0XhOHqyFkFTJIiW/n+BiWX8X/+K fYiXpam3Eq/zeA0L8Mlt75AVeGvWa8OgsC5BOuQbgd/maqqYLzng+cVGA+DxUXZo ZVmzFolc0kSHmzWvMBs/gioejwiefNt8cQjU0uTq4aOPu6JjbA4= =ZiUw -----END PGP SIGNATURE----- --EpRFbj0XIMd8bIjVI41GoduDsQk3zu048--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5e26200c-f1c8-0076-eaa7-d019279e2b30>