From owner-svn-src-all@freebsd.org Fri Feb 23 22:49:02 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C8E3BF2742D; Fri, 23 Feb 2018 22:49:02 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670075.outbound.protection.outlook.com [40.107.67.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1E42D7CF50; Fri, 23 Feb 2018 22:49:01 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM (52.132.66.153) by YQBPR0101MB1459.CANPRD01.PROD.OUTLOOK.COM (52.132.69.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Fri, 23 Feb 2018 22:49:00 +0000 Received: from YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c9:f1bb:c28:946e]) by YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c9:f1bb:c28:946e%13]) with mapi id 15.20.0527.017; Fri, 23 Feb 2018 22:48:59 +0000 From: Rick Macklem To: Konstantin Belousov , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r329875 - head/sys/kern Thread-Topic: svn commit: r329875 - head/sys/kern Thread-Index: AQHTrNPbHhr1sq3e30C2bSmXFyQ5xaOyld/5 Date: Fri, 23 Feb 2018 22:48:59 +0000 Message-ID: References: <201802231826.w1NIQVqr084972@repo.freebsd.org> In-Reply-To: <201802231826.w1NIQVqr084972@repo.freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YQBPR0101MB1459; 7:BaOBtzmlWaFHFw+xEisYG9ZCqBjjK0Kq1ycB2MTRDFMswVYQJdTKUkCgxWZcN9LhSsUnpEv2COt7DzCA6Aa9xOj5rRNPd2xlI/mBh/EMKIc7rHNTejuYN/HTbiNb0WmskeeySHnfwuB7q9tRZq69SPYbd6Ni2Wd1apqv7LDzGmQpE29bJeeXAmA0Letp+fFN3/+nCAIv6GceLQtcFlXe340AbWmC7ccA6uNGVMTXVeRfP5ZJ9afplgl1gdrCoaxH x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 5e6e2131-f31f-4bda-50e7-08d57b0fa110 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989060)(4534165)(4627221)(201703031133081)(201702281549075)(8990040)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:YQBPR0101MB1459; x-ms-traffictypediagnostic: YQBPR0101MB1459: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(56005881305849); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3231200)(944501161)(52105095)(93006095)(93001095)(10201501046)(3002001)(6041288)(20161123562045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:YQBPR0101MB1459; BCL:0; PCL:0; RULEID:; SRVR:YQBPR0101MB1459; x-forefront-prvs: 0592A9FDE6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(366004)(376002)(39380400002)(346002)(396003)(13624006)(199004)(189003)(6306002)(5250100002)(2201001)(9686003)(7696005)(478600001)(105586002)(450100002)(55016002)(99286004)(25786009)(76176011)(2950100002)(68736007)(3660700001)(59450400001)(5660300001)(97736004)(6436002)(6506007)(106356001)(966005)(3280700002)(2900100001)(86362001)(229853002)(316002)(33656002)(26005)(6246003)(81156014)(81166006)(8936002)(8676002)(786003)(102836004)(2906002)(74316002)(74482002)(305945005)(53936002)(186003)(14454004)(2501003)(110136005)(6346003); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1459; H:YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-microsoft-antispam-message-info: tKtTK1moWaRevvKzOIgN3TjELCWmMQvLhjFRb0kwQvsDwO8BoKVpmZHg5naxM5bWFmm340l/QJGi754Zdt/6GpdeRkXXrJ8sBrvX2YGgCa0n7Xb4UydTgUIHNLPRdz62/ENX0tboMIMKfTZ0VcKAUebpsK/XJiozs2NBaK6uV1E= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 5e6e2131-f31f-4bda-50e7-08d57b0fa110 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2018 22:48:59.9407 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1459 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 22:49:03 -0000 Konstantin Belousov wrote: >Author: kib >Date: Fri Feb 23 18:26:31 2018 >New Revision: 329875 >URL: https://svnweb.freebsd.org/changeset/base/329875 > >Log: > Restore UP build. > > Reviewed by: truckman > Sponsored by: The FreeBSD Foundation > >Modified: > head/sys/kern/sched_ule.c > >Modified: head/sys/kern/sched_ule.c >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >--- head/sys/kern/sched_ule.c Fri Feb 23 18:18:42 2018 (r329874) >+++ head/sys/kern/sched_ule.c Fri Feb 23 18:26:31 2018 (r329875) >@@ -1864,6 +1864,7 @@ sched_lend_user_prio(struct thread *td, u_char prio) > td->td_flags |=3D TDF_NEEDRESCHED; > } > >+#ifdef SMP > /* > * This tdq is about to idle. Try to steal a thread from another CPU bef= ore > * choosing the idle thread. >@@ -1945,6 +1946,7 @@ tdq_trysteal(struct tdq *tdq) > } > spinlock_exit(); >} >+#endif > > /* > * Handle migration from sched_switch(). This happens only for >@@ -2058,8 +2060,10 @@ sched_switch(struct thread *td, struct thread *newt= d, > TDQ_LOCK(tdq); > mtx =3D thread_lock_block(td); > tdq_load_rem(tdq, td); >+#ifdef SMP > if (tdq->tdq_load =3D=3D 0) Since the function isn't called for UP, should this "if" also check for ncp= us > 1 by any chance? (I know nothing about ULE, so please ignore this if it doesn't make sense;-= ) > tdq_trysteal(tdq); >+#endif > } > > #if (KTR_COMPILE & KTR_SCHED) !=3D 0 rick=