From owner-freebsd-afs@FreeBSD.ORG Sun Dec 14 02:56:15 2008 Return-Path: Delivered-To: freebsd-afs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57CE2106564A for ; Sun, 14 Dec 2008 02:56:15 +0000 (UTC) (envelope-from matt@linuxbox.com) Received: from aa.linuxbox.com (aa.linuxbox.com [134.215.213.37]) by mx1.freebsd.org (Postfix) with ESMTP id 07CC28FC12 for ; Sun, 14 Dec 2008 02:56:14 +0000 (UTC) (envelope-from matt@linuxbox.com) Received: from trosper.private.linuxbox.com (trosper.private.linuxbox.com [10.1.1.45]) by aa.linuxbox.com (8.13.1/8.13.1/SuSE Linux 0.7) with ESMTP id mBE2uCfe000955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 13 Dec 2008 21:56:12 -0500 Received: by trosper.private.linuxbox.com (Postfix, from userid 65534) id 0964DDB41FB4; Sat, 13 Dec 2008 21:56:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on trosper.private.linuxbox.com X-Spam-Level: X-Spam-Status: No, score=-4.4 required=4.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.1.7 Received: from localhost.localdomain (unknown [10.1.1.217]) by trosper.private.linuxbox.com (Postfix) with ESMTP id AE137DB41FB1; Sat, 13 Dec 2008 21:56:09 -0500 (EST) Message-ID: <494475C2.7000303@linuxbox.com> Date: Sat, 13 Dec 2008 21:56:02 -0500 From: Matt Benjamin User-Agent: Thunderbird 2.0.0.18 (X11/20081105) MIME-Version: 1.0 To: Ben Kaduk References: <47d0403c0812131824i489c50c6w456e62e43ecabdeb@mail.gmail.com> In-Reply-To: <47d0403c0812131824i489c50c6w456e62e43ecabdeb@mail.gmail.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (aa.linuxbox.com [10.1.1.1]); Sat, 13 Dec 2008 21:56:12 -0500 (EST) Cc: freebsd-afs@freebsd.org, Derrick J Brashear Subject: Re: Changes to OpenAFS to support FreeBSD 8-CURRENT X-BeenThere: freebsd-afs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: The Andrew File System and FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Dec 2008 02:56:15 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi Ben, I got your previous email, but wasn't sure I could get to this. I haven't in fact been focused on 8-CURRENT, but on vnode locking and refcounting correctness across 7.0 to 8-CURRENT. (Making headway...) Anyway, I set that aside and whacked through a similar effort. The things you got sound right to me, though I'm surprised krx and afs_server.c compiled, but, it might have to do with whether you have network stack virtualization enabled. The module doesn't load presumably because of unresolved externals--here either the aforementioned (like in_ifaddrhead), and probably "suser(thread)" which is gone, replaced with "priv_check(thread)" (what makes me think that one won't be around long). Openafs-1.4.8 (openafs.org) with RT # 123933 compiles and loads, as above, but I have not run the code, it's just to block something in, ATM. Matt Ben Kaduk wrote: > Hi Boris, > > To get a OpenAFS compiling on a couple-day-old current, I needed to > change (in addition to > the vinvalbuf change mentioned elsewhere) > > VSUID to S_ISUID and VSGID to S_ISGID in VNOPS/afs_vnop_attrs.c > from this change: > trasz 2008-09-10 13:16:41 UTC > (note that S_ISUID is from stat.h and VUID was from vnode.h) > > remove the curthread argument from VOP_GETATTR() (two occurrences) > in FBSD/osi_file.c:143 (this is under AFS_FBSD50_ENV ???) > from this change: > attilio 2008-08-28 15:23:18 UTC > > The vinvalbuf change also affects FBSD/osi_vm.c in two lines. > > change ap->a_mode to ap->a_accmode in FBSD/osi_vnodeops.c:691 > and in the comment above. Arguably, this might be rather a bug > in the vnode_if.h header where the structure is defined > (libafs/MODLOAD/vnode_if.h, apparently). > > Now, everything compiles, but kldload is claiming that libafs.ko > doesn't exist ... > > -Ben Kaduk > _______________________________________________ > freebsd-afs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-afs > To unsubscribe, send any mail to "freebsd-afs-unsubscribe@freebsd.org" - -- Matt Benjamin The Linux Box 206 South Fifth Ave. Suite 150 Ann Arbor, MI 48104 http://linuxbox.com tel. 734-761-4689 fax. 734-769-8938 cel. 734-216-5309 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJRHXBJiSUUSaRdSURCIEPAJsFcRHTBEDsWs4y2r3h0LJlQ7LjzgCdGJS4 uFYwecbqcgAQeA1bXhSnqG4= =f20Q -----END PGP SIGNATURE-----