Date: Mon, 22 Nov 2010 19:39:30 -0800 From: Jason Helfman <jhelfman@e-e.com> To: Torfinn Ingolfsen <tingox@gmail.com> Cc: freebsd-doc@freebsd.org, manolis@freebsd.org, FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: PR's not being picked up (Was Re: becoming a port committor) Message-ID: <20101123033930.GA66678@eggman.experts-exchange.com> In-Reply-To: <AANLkTi=Y3MTcyCxKtAkf9AnS-immBwDYAaxXBHerHPES@mail.gmail.com> References: <4CE7EC0D.9000203@a1poweruser.com> <4CE969B6.90900@kc8onw.net> <AANLkTik7wfhm8hp-Kwfu8HerqYftiYXTCwT6Q83t7Hmv@mail.gmail.com> <201011211909.23708.beech@akherb.com> <20101122052649.GA61979@comcast.net> <4CEA0738.3060701@unfs.us> <20101122072257.GF48679@comcast.net> <20101122131905.318b590c@gumby.homeunix.com> <AANLkTi=Y3MTcyCxKtAkf9AnS-immBwDYAaxXBHerHPES@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline I put together this patch. I hope this is sufficient. Thanks! Jason On Mon, Nov 22, 2010 at 07:58:56PM +0100, Torfinn Ingolfsen thus spake: >Hi, > >On Mon, Nov 22, 2010 at 2:19 PM, RW <rwmaillists@googlemail.com> wrote: > >> >> Actually it does discuss the wording of the synopsis for both new and >> updated ports which gives the impression that that that section covers >> both. >> >> Furthermore the update chapter is at the opposite end of the >> index under the single misleading word "Upgrading". There's no mention >> of "submitting" which is what people will be looking for. >> >> IMO chapter 10 should either be 3.7 or be merged into 3.6. If anything >> deserves to be under "Quick Porting" it's this. >> > >So then we will see your PR for an update of that chapter in the Porter's >Handbook in the next few days perhaps? > > >> The trouble is that even when people do read handbooks from beginning >> to end there are always sections that that they are likely to skip >> until they need them, and this is one of them. >> > >The Porter's Handbook is not going to be improved unless the people who read >it and have ideas for improvement do something about it. > >HTH, HAND. >-- >Regards, >Torfinn Ingolfsen >_______________________________________________ >freebsd-ports@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-ports >To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" > --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" --- porters-handbook/book.sgml 2010-11-22 18:56:43.000000000 -0800 +++ porters-handbook/book.sgml.my 2010-11-22 19:34:25.000000000 -0800 @@ -412,6 +412,22 @@ url="http://www.FreeBSD.org/cgi/query-pr-summary.cgi?category=ports">ports waiting to be committed to &os;</ulink>.</para> + <para>If you are contributing a patch for a port, please <emphasis>do not</emphasis> + submit a shar. The recommeded way for submission of a patch is by using a utility + called <command>/usr/bin/diff</command> which is included as part of the base &os; + distribution. To create a suitable <command>diff</command>, copy the file that + needs patching to <replaceable>something.orig</replaceable>. Save your changes to + <replaceable>something</replaceable> and then create your patch.</para> + + <informalexample> + <screen>&prompt.user; <userinput>/usr/bin/diff something.orig something > somthing.diff + </userinput></screen> + </informalexample> + + <para>Please see the aforementioned step for submission of <replaceable>something.diff + </replaceable> to &os; for consideration by using the &man.send-pr.1; program. + </para> + <para>Once we have looked at your port, we will get back to you if necessary, and put it in the tree. Your name will also appear in the list of <ulink url="&url.articles.contributors;/contrib-additional.html">Additional FreeBSD Contributors</ulink> --3MwIy2ne0vdjdPXF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101123033930.GA66678>