Date: Mon, 26 Apr 1999 22:50:01 -0700 (PDT) From: Dima Sivachenko <dima@Chg.RU> To: freebsd-ports@FreeBSD.org Subject: RE: ports/11328: Upgrade x11-toolkits/fltk Message-ID: <199904270550.WAA22797@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/11328; it has been noted by GNATS.
From: Dima Sivachenko <dima@Chg.RU>
To: freebsd-gnats-submit@freebsd.org
Cc: cpiazza@home.net
Subject: RE: ports/11328: Upgrade x11-toolkits/fltk
Date: Tue, 27 Apr 1999 09:46:57 +0400 (MSD)
> First off let me say that I recognize that Dima is the maintainer for this
> port, but I am somewhat puzzled by some changes.
>
> If I'm off base please let me know.
>
> First:
>
> @@ -20,23 +20,22 @@
>
> LIB_DEPENDS= MesaGL.14:${PORTSDIR}/graphics/Mesa3
>
> -USE_BZIP2= yes
>
> Now, isn't it policy to use BZIP2 where possible if it decreases the
> filesize?
> (from ftp.fltk.org)
> -r--r--r-- 1 root sys 964877 Apr 24 03:38 fltk-1.0.2-source.tar.bz2
> -r--r--r-- 1 root sys 1092094 Apr 24 03:33 fltk-1.0.2-source.tar.gz
I see no reason to force user to install bzip.
>
> Second:
>
> +.if OBJFORMAT=="elf"
> +BROKEN= Due to ELF library format
> .endif
Sorry. I meant OBJFORMAT == "aout". On 2.2.8 it doesnt builds.
>
> Erm... I tested this myself and this port does work on an ELF system (4.0-C).
> This was axed.
>
> Third:
>
> post-install:
>
> - ${SETENV} OBJFORMAT=${PORTOBJFORMAT} ${LDCONFIG} -m ${PREFIX}/lib
> - ${INSTALL_MAN} ${WRKSRC}/documentation/fluid.1 \
> - ${PREFIX}/man/man1
> + @ ${LDCONFIG} -m ${PREFIX}/lib
>
> Besides the addition of many extra tabs in this makefile, this doesn't seem
> right. I quote from http://www.freebsd.org/handbook/porting.html:
>
> The ldconfig line in Makefiles should read:
>
> ${SETENV} OBJFORMAT=${PORTOBJFORMAT} ${LDCONFIG} -m ....
As it is broken for aout, it's no need in it.
>
> In PLIST it should read;
>
> @exec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -m ...
> @unexec /usr/bin/env OBJFORMAT=%%PORTOBJFORMAT%% /sbin/ldconfig -R
>
Here the same.
> I have changed all of these and attached the updated port below.
> NOTE:
> pkg/PLIST.nodocs was removed.
www.freebsd.org/handbook/porting.html states that "I shouldnt worry about
NOPORTDOCS in PLIST". I think we should not make a port more complicated
maintaining two copies of PLIST.
NOTE: ftp.fltt.org and ftp.easysw.com have the same IP. I don't know why you
again added it to the MASTER_SITE list!
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199904270550.WAA22797>