From owner-cvs-all@FreeBSD.ORG Mon Jun 28 00:02:08 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42A4D16A4CE; Mon, 28 Jun 2004 00:02:08 +0000 (GMT) Received: from hood.oook.cz (hood.oook.cz [212.27.205.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4495443D41; Mon, 28 Jun 2004 00:02:07 +0000 (GMT) (envelope-from pav@FreeBSD.org) Received: from hood.oook.cz (localhost.oook.cz [127.0.0.1]) by hood.oook.cz (8.12.11/8.12.11) with ESMTP id i5S01tXc005730 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 28 Jun 2004 02:01:55 +0200 (CEST) (envelope-from pav@FreeBSD.org) Received: (from pav@localhost) by hood.oook.cz (8.12.11/8.12.11/Submit) id i5S01svE005729; Mon, 28 Jun 2004 02:01:54 +0200 (CEST) (envelope-from pav@FreeBSD.org) X-Authentication-Warning: hood.oook.cz: pav set sender to pav@FreeBSD.org using -f From: Pav Lucistnik To: Greg Lewis In-Reply-To: <20040627235229.GA36136@misty.eyesbeyond.com> References: <200406271812.i5RICLjj014328@repoman.freebsd.org> <20040627235229.GA36136@misty.eyesbeyond.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-1lTAHWqIgpJxT4LXBrVa" Message-Id: <1088380914.969.10.camel@hood.oook.cz> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Mon, 28 Jun 2004 02:01:54 +0200 cc: cvs-ports@FreeBSD.org cc: Kirill Ponomarew cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/math/gnuplot Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: pav@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2004 00:02:08 -0000 --=-1lTAHWqIgpJxT4LXBrVa Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable V po, 28. 06. 2004 v 01:52, Greg Lewis p=ED=B9e: > > FreeBSD ports repository > >=20 > > Modified files: > > math/gnuplot Makefile=20 > > Log: > > Fix OPTIONS > > =20 > > PR: ports/68388 > > Submitted by: Ports Fury >=20 > So, what exactly is wrong with doing >=20 > .if defined(WITH_OPTION) > stuff > .else > other stuff > .endif >=20 > that >=20 > .if defined(WITHOUT_OPTION) > other stuff > .else > stuff > .endif >=20 > fixes? The only thing I can think of is that it may be prefered to test = the > WITHOUT_OPTION variable when the default is on. Is that it? In the unattended build, when no OPTIONS dialog is displayed, you don't have any WITH* and WITHOUT* variables set. Your port should behave as if default values were selected. OPTIONS=3D OPTION "foo" on Default is to have OPTION on. When no WITH/WITHOUT* variables are generated, your test .if defined(WITH_OPTION) will fail. That's now the default you wanted. If you check instead .if !defined(WITHOUT_OPTION) it will work correctly in case OPTIONS were not processed. This nicely demonstrates in unattended build on packages on Bento, for example. > Also, why wasn't the PR assigned to the maintainer (me :)? Ask krion :) --=20 Pav Lucistnik lofi> My _sympathetic_ opinion about kdevelop is that it's a huge pile of shit that might at least work okay if used in Linux. lofi> My neutral opinion is that it's just a huge pile of shit. --=-1lTAHWqIgpJxT4LXBrVa Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?= =?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBA31/yntdYP8FOsoIRAidmAJ42G/3z3KTiPkdJ50+qil9HaLXrgwCdFa6A Mlw1bKig32iqdmXu8MkKo5M= =Ntf+ -----END PGP SIGNATURE----- --=-1lTAHWqIgpJxT4LXBrVa--