Date: Mon, 28 Jun 2004 02:01:54 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Greg Lewis <glewis@eyesbeyond.com> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/math/gnuplot Makefile Message-ID: <1088380914.969.10.camel@hood.oook.cz> In-Reply-To: <20040627235229.GA36136@misty.eyesbeyond.com> References: <200406271812.i5RICLjj014328@repoman.freebsd.org> <20040627235229.GA36136@misty.eyesbeyond.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-1lTAHWqIgpJxT4LXBrVa
Content-Type: text/plain; charset=iso-8859-2
Content-Transfer-Encoding: quoted-printable
V po, 28. 06. 2004 v 01:52, Greg Lewis p=ED=B9e:
> > FreeBSD ports repository
> >=20
> > Modified files:
> > math/gnuplot Makefile=20
> > Log:
> > Fix OPTIONS
> > =20
> > PR: ports/68388
> > Submitted by: Ports Fury
>=20
> So, what exactly is wrong with doing
>=20
> .if defined(WITH_OPTION)
> stuff
> .else
> other stuff
> .endif
>=20
> that
>=20
> .if defined(WITHOUT_OPTION)
> other stuff
> .else
> stuff
> .endif
>=20
> fixes? The only thing I can think of is that it may be prefered to test =
the
> WITHOUT_OPTION variable when the default is on. Is that it?
In the unattended build, when no OPTIONS dialog is displayed, you don't
have any WITH* and WITHOUT* variables set. Your port should behave as if
default values were selected.
OPTIONS=3D OPTION "foo" on
Default is to have OPTION on. When no WITH/WITHOUT* variables are
generated, your test
.if defined(WITH_OPTION)
will fail. That's now the default you wanted. If you check instead
.if !defined(WITHOUT_OPTION)
it will work correctly in case OPTIONS were not processed. This nicely
demonstrates in unattended build on packages on Bento, for example.
> Also, why wasn't the PR assigned to the maintainer (me :)?
Ask krion :)
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
lofi> My _sympathetic_ opinion about kdevelop is that it's a huge pile
of shit that might at least work okay if used in Linux.
lofi> My neutral opinion is that it's just a huge pile of shit.
--=-1lTAHWqIgpJxT4LXBrVa
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?=
=?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?=
=?ISO-8859-1?Q?_zpr=E1vy?=
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQBA31/yntdYP8FOsoIRAidmAJ42G/3z3KTiPkdJ50+qil9HaLXrgwCdFa6A
Mlw1bKig32iqdmXu8MkKo5M=
=Ntf+
-----END PGP SIGNATURE-----
--=-1lTAHWqIgpJxT4LXBrVa--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1088380914.969.10.camel>