From owner-svn-ports-head@freebsd.org Fri Feb 5 19:53:01 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09016A771CB; Fri, 5 Feb 2016 19:53:01 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DADD71A8E; Fri, 5 Feb 2016 19:53:00 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.1.21] (248.Red-83-39-200.dynamicIP.rima-tde.net [83.39.200.248]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 6755243552; Fri, 5 Feb 2016 13:52:57 -0600 (CST) Subject: Re: svn commit: r408262 - head/editors/uemacs To: Bryan Drewery , John Marino , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201602051859.u15IxnEx021230@repo.freebsd.org> <56B4FC78.6050005@FreeBSD.org> Reply-To: marino@freebsd.org From: John Marino Message-ID: <56B4FD92.9080504@marino.st> Date: Fri, 5 Feb 2016 20:52:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56B4FC78.6050005@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2016 19:53:01 -0000 On 2/5/2016 8:48 PM, Bryan Drewery wrote: > On 2/5/2016 10:59 AM, John Marino wrote: >> Author: marino >> Date: Fri Feb 5 18:59:49 2016 >> New Revision: 408262 >> URL: https://svnweb.freebsd.org/changeset/ports/408262 >> >> Log: >> editors/uemacs: document ncurses rqmt (USES+=ncurses), respect LDFLAGS >> >> Also link with ncurses, not termcap >> >> approved by: infrastructure blanket >> >> Modified: >> head/editors/uemacs/Makefile >> >> Modified: head/editors/uemacs/Makefile >> ============================================================================== >> --- head/editors/uemacs/Makefile Fri Feb 5 18:57:54 2016 (r408261) >> +++ head/editors/uemacs/Makefile Fri Feb 5 18:59:49 2016 (r408262) >> @@ -13,10 +13,12 @@ COMMENT= Full screen editor >> NO_CDROM= Resale allowed for media cost only >> >> NO_WRKSUBDIR= yes >> -USES= dos2unix zip >> +USES= dos2unix ncurses zip >> EXTRACT_BEFORE_ARGS= -Lq >> >> post-patch: >> @${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/src/*.c >> + @${REINPLACE_CMD} -e 's|-ltermcap|${LDFLAGS} -lncurses|g' \ >> + ${WRKSRC}/freebsd/makefile >> >> .include >> > > lrwxr-xr-x 1 root wheel 13 Mar 27 2015 /usr/lib/libtermcap.so@ -> > libncurses.so > > libtermcap is symlinked to libncurses. Why is it worth maintaining extra > code to link to ncurses directly? > Libtermcap does not exist in ports, it's not in devel/ncurses. If one wants doesn't want to use base, the port can't be built. The obvious solution is make everythink link with libncurses so both base and ports options are supported.