From owner-p4-projects@FreeBSD.ORG  Wed Sep 12 22:18:31 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 85D4116A419; Wed, 12 Sep 2007 22:18:31 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 51B0616A417
	for <perforce@freebsd.org>; Wed, 12 Sep 2007 22:18:31 +0000 (UTC)
	(envelope-from kip.macy@gmail.com)
Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.233])
	by mx1.freebsd.org (Postfix) with ESMTP id 0E1B113C45A
	for <perforce@freebsd.org>; Wed, 12 Sep 2007 22:18:30 +0000 (UTC)
	(envelope-from kip.macy@gmail.com)
Received: by nz-out-0506.google.com with SMTP id l8so224742nzf
	for <perforce@freebsd.org>; Wed, 12 Sep 2007 15:18:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	bh=WFXKdXGx+hXNOqyFYE8AbwQlbij914MY6+V/wXQDc2c=;
	b=GnS5mxz+DUKZnQm17IYczNC9sf/5PMItBuTvNc82hI1IJOtkiAN7XlXq1UAb6RpgOpp1nkefskpApU3251aBWY7/44hWR5G5f8HN1RFr32qXsRS8WdzOzWEmkP7gV3BH1AZIlFTOSoqS8lIYnEoVtL3b0nheZWJ6miOf8kULCEQ=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=NIew59bV4Gai3VLom2OlpUIegfs3gu+d/Bak1WFIAYxJDtat0QVJixgHUx+hbbBX3/D4LG3iz5ubkSQ9OL0CfgxT6Dyf9vZEcE5uy6M7SFiOyZn2Dpu0GwIQHLx0tGE76mspdBOrIFsZseqLWmiuqU0TRHhGMmLEMAWQ55lp39k=
Received: by 10.114.121.1 with SMTP id t1mr28527wac.1189633846025;
	Wed, 12 Sep 2007 14:50:46 -0700 (PDT)
Received: by 10.114.13.15 with HTTP; Wed, 12 Sep 2007 14:50:46 -0700 (PDT)
Message-ID: <b1fa29170709121450r5f59430bqa13373fdf807cadc@mail.gmail.com>
Date: Wed, 12 Sep 2007 14:50:46 -0700
From: "Kip Macy" <kip.macy@gmail.com>
To: "Pawel Jakub Dawidek" <pjd@freebsd.org>
In-Reply-To: <20070912150017.GA3553@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200709120832.l8C8WLlm085731@repoman.freebsd.org>
	<20070912150017.GA3553@garage.freebsd.pl>
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	Kip Macy <kmacy@freebsd.org>
Subject: Re: PERFORCE change 126330 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Sep 2007 22:18:31 -0000

On 9/12/07, Pawel Jakub Dawidek <pjd@freebsd.org> wrote:
> On Wed, Sep 12, 2007 at 08:32:21AM +0000, Kip Macy wrote:
> > http://perforce.freebsd.org/chv.cgi?CH=126330
> >
> > Change 126330 by kmacy@kmacy_home:ethng on 2007/09/12 08:31:36
> >
> >       convert radix node head and route locks from mutexes to rwlocks
> [...]
> >               rt->rt_flags |= RTF_LLINFO;
> > -             callout_init_mtx(&la->la_timer, &rt->rt_mtx,
> > -                 CALLOUT_RETURNUNLOCKED);
> > +             callout_init_rwlock(&la->la_timer, &rt->rt_lock,
> > +                 CALLOUT_RETURNUNLOCKED_RW);
> >
>
> Kip, don't add callout_init_rwlock() to the tree. I've
> callout_init_lock() implemented that operates on any lock type, just
> like condvar(9).

point me to a diff