From owner-svn-ports-all@FreeBSD.ORG Fri Mar 27 13:14:02 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CDE2F9E1 for ; Fri, 27 Mar 2015 13:14:02 +0000 (UTC) Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 938A616 for ; Fri, 27 Mar 2015 13:14:02 +0000 (UTC) Received: by oicf142 with SMTP id f142so66223986oic.3 for ; Fri, 27 Mar 2015 06:14:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=5egcnvLChMH5qQEc+4apLUWr/zFbpi11bQHDI/ac6tY=; b=nJ0b2M+pw9PdGrDAY9iljepneehaBelTFTFIaW+I4MFmZvDJQF2e9L2joIb6nDfmy7 A4VSYTnVphgL+VJhMkcXqDOW7C1e8uBQtVutrHXESHvoxdKPaPkkCZcduQie8k4E3tiA 7/p/rdB7etFO4BD+6vxbitESME2uLJeBTbDKmObGjkeRSl9kxwvtyz26S8tcnJyydOfN IJL67vKDTG+xSFEkVRcGVaLVAdA/ezWD52UE5ODyFyyEG0mjDfSjUSC8nR342gd5fAv7 4pgbiT5EsFpX+5A2+wk923UTLcfWEBEd5gK2FRu/u/duIoraOjh6MYvgYbXADdzIoJ53 EQDA== X-Gm-Message-State: ALoCoQkMMphtORqMtDlyDzNo/yPgsdrkASRjLpv6PIs5s5MCFFxmpGvEBRU4aKbHzeg3Im1cjbGv X-Received: by 10.182.224.198 with SMTP id re6mr2591981obc.49.1427461598722; Fri, 27 Mar 2015 06:06:38 -0700 (PDT) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.202.61.139 with HTTP; Fri, 27 Mar 2015 06:06:18 -0700 (PDT) In-Reply-To: <201503261933.t2QJXana047644@svn.freebsd.org> References: <201503261933.t2QJXana047644@svn.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Fri, 27 Mar 2015 21:06:18 +0800 X-Google-Sender-Auth: 32LaqkOs32q39ttoa3r2hHOddNg Message-ID: Subject: Re: svn commit: r382338 - head/devel/hub To: Steve Wills Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2015 13:14:02 -0000 On Fri, Mar 27, 2015 at 3:33 AM, Steve Wills wrote: > Author: swills > Date: Thu Mar 26 19:33:35 2015 > New Revision: 382338 > URL: https://svnweb.freebsd.org/changeset/ports/382338 > QAT: https://qat.redports.org/buildarchive/r382338/ > > Log: > devel/hub: update to 2.2.0 > > PR: 197999 > Submitted by: swills (myself) > Approved by: koukopoulos@gmail.com (maintainer) > > Modified: > head/devel/hub/Makefile > head/devel/hub/distinfo > > Modified: head/devel/hub/Makefile > > ============================================================================== > --- head/devel/hub/Makefile Thu Mar 26 19:24:15 2015 (r382337) > +++ head/devel/hub/Makefile Thu Mar 26 19:33:35 2015 (r382338) > @@ -2,7 +2,7 @@ > # $FreeBSD$ > > PORTNAME= hub > -PORTVERSION= 1.12.2 > +PORTVERSION= 2.2.0 > CATEGORIES= devel > > MAINTAINER= koukopoulos@gmail.com > @@ -12,22 +12,27 @@ LICENSE= MIT > > USE_GITHUB= yes > GH_ACCOUNT= github > -GH_TAGNAME= v${DISTVERSION} > -GH_COMMIT= 9016a39 > > -USE_RUBY= yes > -USE_RAKE= yes > +DISTVERSIONPREFIX=v > + > +MASTER_SITES= GH > + > +BUILD_DEPENDS= go:${PORTSDIR}/lang/go \ > + bash:${PORTSDIR}/shells/bash > + > +WRKSRC= ${WRKDIR}/${PORTNAME}-${PORTVERSION} > + > +STRIP= # stripping can break go binaries > > PLIST_FILES= bin/hub \ > etc/bash_completion.d/hub \ > share/zsh/site-functions/_hub \ > man/man1/hub.1.gz > - > do-build: > - @cd ${WRKSRC} && ${RAKE_BIN} standalone > + @cd ${WRKSRC} ; ${SETENV} ${LOCALBASE}/bin/bash script/build > > do-install: > - ${INSTALL_SCRIPT} ${WRKSRC}/hub ${STAGEDIR}${PREFIX}/bin > + ${INSTALL_PROGRAM} ${WRKSRC}/hub ${STAGEDIR}${PREFIX}/bin > ${INSTALL_MAN} ${WRKSRC}/man/hub.1 > ${STAGEDIR}${MAN1PREFIX}/man/man1 > @${MKDIR} ${STAGEDIR}${PREFIX}/etc/bash_completion.d > ${INSTALL_DATA} ${WRKSRC}/etc/hub.bash_completion.sh > ${STAGEDIR}${PREFIX}/etc/bash_completion.d/hub > > Modified: head/devel/hub/distinfo > > ============================================================================== > --- head/devel/hub/distinfo Thu Mar 26 19:24:15 2015 (r382337) > +++ head/devel/hub/distinfo Thu Mar 26 19:33:35 2015 (r382338) > @@ -1,2 +1,2 @@ > -SHA256 (hub-1.12.2.tar.gz) = > 98003caa613ae94fffd6611f1f3e9b58d906349d0579b8aca16f137cb13a5347 > -SIZE (hub-1.12.2.tar.gz) = 76606 > +SHA256 (hub-v2.2.0_GH0.tar.gz) = > 2da1351197eb5696c207f22c69a5422af052d74277b73d0b8661efb9ec1d0eb1 > +SIZE (hub-v2.2.0_GH0.tar.gz) = 301460 > > Hi Steve, I have several suggestions: - With r382120, I think GH_TAGNAME=v${PORTVERSION} is better than DISTVERSIONPREFIX=v. - MASTER_SITES can be removed if github.com is the only master site. USE_GITHUB will handle it. - To pet portlint, move BUILD_DEPENDS after the LICENSE section. Here's my patch at https://people.freebsd.org/~sunpoet/hub.patch Regards, sunpoet