From owner-svn-src-all@FreeBSD.ORG Mon May 4 16:42:21 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 13638DDA for ; Mon, 4 May 2015 16:42:21 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D25111644 for ; Mon, 4 May 2015 16:42:20 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t44GgKhI092716 for ; Mon, 4 May 2015 16:42:20 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t44GgKCt092711 for svn-src-all@freebsd.org; Mon, 4 May 2015 16:42:20 GMT (envelope-from bdrewery) Received: (qmail 31105 invoked from network); 4 May 2015 11:42:19 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 4 May 2015 11:42:19 -0500 Message-ID: <5547A175.2010408@FreeBSD.org> Date: Mon, 04 May 2015 11:42:29 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Baptiste Daroussin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282420 - in head: . etc/mtree lib/libevent lib/libucl share/mk References: <201505041628.t44GStT1002366@svn.freebsd.org> In-Reply-To: <201505041628.t44GStT1002366@svn.freebsd.org> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fvAxgqvlVQVn51XhMWfgxrPPrLOkIfARS" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 16:42:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fvAxgqvlVQVn51XhMWfgxrPPrLOkIfARS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/4/2015 11:28 AM, Baptiste Daroussin wrote: > +LIBATF_C=3D $(DESTDIR)$(LIBDIR)/libprivateatf-c.a > +LIBATF_CXX=3D $(DESTDIR)$(LIBDIR)/libprivateatf-c++.a > +LDADD_atf_c=3D -lprivateatf-c > +LDADD_atf_cxx=3D -lprivateatf-c++ > + > +.for _l in ${_PRIVATELIBS} > +LIB${_l:tu}?=3D ${DESTDIR}${LIBDIR}/libprivate${_l}.a Style-wise I see bugs here. Let's stick to () or {}. --=20 Regards, Bryan Drewery --fvAxgqvlVQVn51XhMWfgxrPPrLOkIfARS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVR6F1AAoJEDXXcbtuRpfPdjEIAJVsaWfnzzA1g3UUOZumaPfQ WiviRx/UvfxmlzaDx+xM44X+S3f3Pg65MtIeN7uo/WjINj/xEk/+ZcBDUVv80Z2x FgqB2roLKnMN5SL4LZEbsfaAvEWkgXJZFeVh2mUj+PY6mwd4Bt/R8M0MYjBLyoS0 NXd9f6DeRQpsu8hcz8mcfFJst/UOMsvPTTmmyNlAW7HjKMZT4bQIrvWq4drpqkG/ wqRwHhVDZ2GrrI5iRNjJOM4RNisytMvDWqXXgrckiXPOstmuD8pGuhixFCEwdHwS UHl/F/h+I+iX9tuMXYh3WBIwlQ8iOuwuLPR7DarxiG3sP1SjCGCaq2CD6EFOiFM= =QZwC -----END PGP SIGNATURE----- --fvAxgqvlVQVn51XhMWfgxrPPrLOkIfARS--