From owner-freebsd-net@freebsd.org Sun Jan 10 19:58:51 2016 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4DFB0A6A2CC for ; Sun, 10 Jan 2016 19:58:51 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp004.me.com (mr11p00im-asmtp004.me.com [17.110.69.135]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 39F791322 for ; Sun, 10 Jan 2016 19:58:51 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from [192.168.1.4] (c-24-6-178-251.hsd1.ca.comcast.net [24.6.178.251]) by mr11p00im-asmtp004.me.com (Oracle Communications Messaging Server 7.0.5.36.0 64bit (built Sep 8 2015)) with ESMTPSA id <0O0R002TT661MC00@mr11p00im-asmtp004.me.com> for freebsd-net@freebsd.org; Sun, 10 Jan 2016 19:58:50 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-01-10_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1011 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1510270003 definitions=main-1601100376 User-Agent: Microsoft-MacOutlook/0.0.0.151217 Date: Sun, 10 Jan 2016 11:58:49 -0800 Subject: Re: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth From: Ravi Pokala Sender: "Pokala, Ravi" To: Sepherosa Ziehau , Ravi Pokala Cc: "freebsd-net@freebsd.org" Message-id: Thread-topic: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth References: In-reply-to: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Jan 2016 19:58:51 -0000 -----Original Message----- From: Sepherosa Ziehau Date: 2016-01-10, Sunday at 00:31 To: Ravi Pokala Cc: "freebsd-net@freebsd.org" Subject: Re: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth >On Fri, Jan 8, 2016 at 11:59 PM, Ravi Pokala wrote: >> >>... >> >> Forgive me if I'm missing something obvious, but this patch doesn't actually change anything - rather than hard-coding 65535, you're using lc->lro_hiwat... which is hard-coded to 65535. >> >> Right? > >The value is intended to be changed by NIC drivers, see the code >commented out by the HN_LRO_HIWAT here: >https://reviews.freebsd.org/D4824 Cool. In that case, please mention the fact that it is currently unused when you submit the change. :-) Thanks, Ravi (rpokala@) >Thanks, >sephe