From nobody Mon Jul 7 12:51:00 2025 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbPJt5zs9z61fCT for ; Mon, 07 Jul 2025 12:52:14 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbPJs5fS3z3qSC for ; Mon, 07 Jul 2025 12:52:13 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none) Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 567Cp0bC062465; Mon, 7 Jul 2025 15:51:03 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 567Cp0bC062465 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 567Cp0Cd062463; Mon, 7 Jul 2025 15:51:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 7 Jul 2025 15:51:00 +0300 From: Konstantin Belousov To: Oleg Nauman Cc: FreeBSD Current , David Wolfskill Subject: Re: tail -f is broken in recent CURRENT ( afd5bc630930 Sunday Jul 6 ) Message-ID: References: List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Result: default: False [2.88 / 15.00]; NEURAL_SPAM_LONG(1.00)[1.000]; NEURAL_SPAM_MEDIUM(1.00)[0.998]; NEURAL_SPAM_SHORT(0.88)[0.882]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MISSING_XM_UA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; R_SPF_SOFTFAIL(0.00)[~all]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; HAS_XAW(0.00)[]; R_DKIM_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 4bbPJs5fS3z3qSC X-Spamd-Bar: ++ On Mon, Jul 07, 2025 at 03:36:12PM +0300, Oleg Nauman wrote: > I noticed that > tail -f /var/log/messages never receive updates if running with recent > CURRENT ( afd5bc630930 Sunday Jul 6 ) > > 60092: read(3,"talled\nJul 6 16:59:54 mysystem pkg-static[86368]: > gstreamer1-plugins-mpg123-1.26.2 deinstalled\nJul 6 16:59:57 mysytem > pkg"...,32768) = 2666 (0xa6a) > 60092: munmap(0x801403000,297578) = 0 (0x0) > 60092: read(3,0x80182c600,32768) = 0 (0x0) > 60092: kqueue() = 5 (0x5) > 60092: fstatfs(3,{ > fstypename=ufs,mntonname=/,mntfromname=/dev/gpt/FreeBSD-UFS,fsid=133a996124e0f956 > }) = 0 (0x0) > 60092: kevent(5,{ 3,EVFILT_READ,EV_ADD|EV_ENABLE|EV_CLEAR,0,0,0x0 > },1,0x0,0,{ 0.000000000 }) = 0 (0x0) > 60092: kevent(5,0x0,0,0x801814000,1,0x0) ERR#4 'Interrupted > system call' <--- killed at this point by me > 60095: select(7,{ 6 },0x0,0x0,0x0) ERR#4 'Interrupted system call' > 60092: SIGNAL 2 (SIGINT) code=SI_KERNEL > 60095: SIGNAL 2 (SIGINT) code=SI_KERNEL > 60095: process killed, signal = 2 > 60092: process killed, signal = 2 > > Likely something is wrong with kqueue and/or kevent Try this diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h index 3ed469bdce6d..2c6947103c94 100644 --- a/sys/sys/vnode.h +++ b/sys/sys/vnode.h @@ -1032,7 +1032,7 @@ void vop_rename_fail(struct vop_rename_args *ap); #define VOP_WRITE_POST(ap, ret) \ noffset = (ap)->a_uio->uio_offset; \ if (noffset > ooffset) { \ - if (VN_KNLIST_EMPTY((ap)->a_vp)) { \ + if (!VN_KNLIST_EMPTY((ap)->a_vp)) { \ VFS_KNOTE_LOCKED((ap)->a_vp, NOTE_WRITE | \ (noffset > osize ? NOTE_EXTEND : 0)); \ } \