From owner-cvs-all@FreeBSD.ORG Sat Mar 20 13:17:10 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3501B16A523 for ; Sat, 20 Mar 2004 13:17:09 -0800 (PST) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDB3843E1C for ; Sat, 20 Mar 2004 12:53:59 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 11070 invoked from network); 20 Mar 2004 20:53:59 -0000 Received: from dsl017-045-168.spk4.dsl.speakeasy.net (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail1.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 20 Mar 2004 20:53:59 -0000 Received: from hydrogen.funkthat.com (wnetwv@localhost.funkthat.com [127.0.0.1])i2KKrwOE066481; Sat, 20 Mar 2004 12:53:58 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id i2KKruba066480; Sat, 20 Mar 2004 12:53:56 -0800 (PST) Date: Sat, 20 Mar 2004 12:53:56 -0800 From: John-Mark Gurney To: Marcel Moolenaar Message-ID: <20040320205356.GE567@funkthat.com> References: <200403200214.i2K2E3ps052217@repoman.freebsd.org> <20040320080027.GC567@funkthat.com> <20040320085431.GA74398@dhcp01.pn.xcllnt.net> <20040320185640.GD567@funkthat.com> <20040320201610.GC84959@dhcp01.pn.xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040320201610.GC84959@dhcp01.pn.xcllnt.net> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files src/sys/dev/uart uart_cpu.h uart_cpu_alpha.c uart_cpu_amd64.c uart_cpu_i386.c uart_cpu_ia64.c uart_cpu_pc98.c uart_cpu_sparc64.c uart_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Mar 2004 21:17:10 -0000 Marcel Moolenaar wrote this message on Sat, Mar 20, 2004 at 12:16 -0800: > > > Probe order is irrelevant if you specify the device by its I/O port > > > or memory mapped I/O address. When you need to pinpoint a device > > > prior to any form of bus enumeration, the unit number is meaningless > > > and any mechanism that includes a unit number is bogus. That's why > > > hints are the wrong tool for pinpointing a console or debug port. > > > > I hope that you don't have to specify the console via io/memory port.. > > Yes you have. This is no different than hints, except that you set > flags in that case to tell uart(4) that the device is to be used as > a console or debug port. But you still need to specify the I/O port > because without it your hint is bogus. My objection is to Yet Another Hint Place to stick IO/Memory wiring down addresses... If you need to specify IO or memory mapped addresses w/ io or mm, then you have enough information to instead specify the device such as sio5, and then get the io or mm from the hints for that device... currently, you have: hw.uart.console="io=0x3f8:br=9600:[...]" now why couldn't that be changed to (or whatever you name the device): hw.uart.console="dv=uart0" hint.uart.0.port="0x3f8" It does everything your patch does w/o scattering device information in random places that isn't hint... Personally, I also think that if you want to set baudrate and other paramters, they should be: hint.uart.0.baudrate="9600" etc. Since this is all hints for the device/console that specify parameters for the device... of course, we really should have a: hint.console.0.dev="uart0" or: hint.console.0.dev="uart0:sio0:sc0" Specifing the order in which we prefer the various devices... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."