From owner-svn-src-all@FreeBSD.ORG Sun Jul 28 18:46:57 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 0C9D1FBE; Sun, 28 Jul 2013 18:46:57 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D516E258B; Sun, 28 Jul 2013 18:46:56 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1V3VzW-00035V-2h; Sun, 28 Jul 2013 18:46:50 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r6SIkkvX016209; Sun, 28 Jul 2013 12:46:46 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+XiPoUGTkjwBHjZPoKb5Km Subject: Re: svn commit: r253744 - head/usr.sbin/watchdogd From: Ian Lepore To: Glen Barber In-Reply-To: <20130728184204.GI2272@glenbarber.us> References: <201307281656.r6SGuVYx023459@svn.freebsd.org> <20130728184204.GI2272@glenbarber.us> Content-Type: text/plain; charset="us-ascii" Date: Sun, 28 Jul 2013 12:46:46 -0600 Message-ID: <1375037206.45247.17.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2013 18:46:57 -0000 On Sun, 2013-07-28 at 14:42 -0400, Glen Barber wrote: > On Sun, Jul 28, 2013 at 04:56:31PM +0000, Ian Lepore wrote: > > Author: ian > > Date: Sun Jul 28 16:56:31 2013 > > New Revision: 253744 > > URL: http://svnweb.freebsd.org/changeset/base/253744 > > > > Log: > > Fix printf of seconds for systems where time_t is 64 bits. > > > > Modified: > > head/usr.sbin/watchdogd/watchdogd.c > > > > Modified: head/usr.sbin/watchdogd/watchdogd.c > > ============================================================================== > > --- head/usr.sbin/watchdogd/watchdogd.c Sun Jul 28 16:50:45 2013 (r253743) > > +++ head/usr.sbin/watchdogd/watchdogd.c Sun Jul 28 16:56:31 2013 (r253744) > > @@ -50,6 +50,7 @@ __FBSDID("$FreeBSD$"); > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -230,10 +231,10 @@ parse_timeout_to_pow2ns(char opt, const > > if (debugging) { > > printf("Timeout for %s%s " > > "is 2^%d nanoseconds " > > - "(in: %s sec -> out: %ld sec %ld ns -> %d ticks)\n", > > + "(in: %s sec -> out: %jd sec %ld ns -> %d ticks)\n", > > longopt ? "-" : "", longopt ? longopt : shortopt, > > rv, > > - myoptarg, ts.tv_sec, ts.tv_nsec, ticks); > > + myoptarg, (intmax_t)ts.tv_sec, ts.tv_nsec, ticks); > > This breaks head/ for at least arm. > > cc -O -pipe -std=gnu99 -Qunused-arguments -Wsystem-headers -Werror > -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign > -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare > -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function > -Wno-conversion -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -o watch watch.o -ltermcap > gzip -cn /src/usr.sbin/watch/watch.8 > watch.8.gz > ===> usr.sbin/watchdogd (all) > cc -O -pipe -std=gnu99 -Qunused-arguments -Wsystem-headers -Werror > -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual > -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls > -Wold-style-definition -Wmissing-variable-declarations -Wno-pointer-sign > -Wno-empty-body -Wno-string-plus-int -c > /src/usr.sbin/watchdogd/watchdogd.c > /src/usr.sbin/watchdogd/watchdogd.c:236:17: error: format specifies type > 'long' but the argument has type 'time_t' (aka 'long long') > [-Werror,-Wformat] > myoptarg, ts.tv_sec, ts.tv_nsec, ticks); > ^~~~~~~~~ > 1 error generated. > *** Error code 1 > > Stop. > bmake: stopped in /src/usr.sbin/watchdogd > *** Error code 1 > > http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-armv6-arm.full > > Glen > Umm, no, it fixes the error you cite (tinderbox hasn't caught up to the fix yet). -- Ian