Date: Fri, 19 Apr 2024 13:05:29 +0200 From: =?UTF-8?B?VMSzbA==?= Coosemans <tijl@FreeBSD.org> To: Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: "Tobias C. Berner" <tcberner@gmail.com>, Gleb Popov <arrowd@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" Message-ID: <20240419130529.6068bc4b@hal.tijl.coosemans.org> In-Reply-To: <CAMHz58RqvKTL=5C8ZX0YsENfsgoSYhV3pdFANFX5myeVuZT-cw@mail.gmail.com> References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <CALH631=Q0Hc%2BYnvREbe0aNR%2BVeWaNv3YdekKmeUe_Kf6tXD6TQ@mail.gmail.com> <2567403.0dHE6SNnxz@angua.firefly> <CAMHz58Qa2pyN6qs-mFr9aHgtQoGrd1hbhF=ahx5ahR-0CB-7uQ@mail.gmail.com> <20240324202715.5d18838d@hal.tijl.coosemans.org> <CAMHz58QZ0bQh51s4j9CNt7yRZX8=uQi-cDp3ok6FN8ie0v=Gbw@mail.gmail.com> <20240331234553.1793b816@hal.tijl.coosemans.org> <CAMHz58RqvKTL=5C8ZX0YsENfsgoSYhV3pdFANFX5myeVuZT-cw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 9 Apr 2024 05:08:10 +0800 Po-Chuan Hsieh wrote:
> On Mon, Apr 1, 2024 at 5:46=E2=80=AFAM T=C4=B3l Coosemans <tijl@freebsd.o=
rg> wrote:
>> On Mon, 1 Apr 2024 04:17:09 +0800 Po-Chuan Hsieh wrote:
>>> On Mon, Mar 25, 2024 at 3:27=E2=80=AFAM T=C4=B3l Coosemans <tijl@freebs=
d.org> wrote:
>>>> - Some fonts have been split into x11-fonts/<font>-basic providing Bol=
d,
>>>> BoldItalic, Italic, and Regular, and x11-fonts/<font>-extra providing
>>>> additional styles. Only some of these have x11-fonts/<font> as a
>>>> metaport currently. This needs to be made consistent. I think it
>>>> would be best to drop the metaports and move x11-fonts/<font>-basic =
to
>>>> x11-fonts/<font>. That way pkg install <font> installs the common
>>>> styles for all fonts. I think that this would be the most
>>>> intuitive/convenient.
>>>> (I was hoping to use subpackages for this instead of extra ports.)
>>>
>>> The -basic/-extra structure was kept for minimal change.
>>> I agree with you that it would be better to be consistent with all other
>>> noto ports.
>>> I could merge the following ports:
>>> - noto-sans-basic/-extra
>>> - noto-sans-mono-basic/-extra
>>> - noto-sans-symbols-basic/-extra
>>> - noto-serif-basic/-extra
>>> However, what should be noto-basic's dependencies after the merge?
>>
>> It's okay to keep the -extra ports. What I meant was to rename the
>> -basic ports so noto-sans-basic becomes noto-sans for example.
>=20
> I've prepared a patch [1] for the following changes:
> - Merge x11-fonts/noto-sans-{basic,extra} to x11-fonts/noto-sans
> - Merge x11-fonts/noto-sans-mono-{basic,extra} to x11-fonts/noto-sans-mono
> - Merge x11-fonts/noto-sans-symbols-{basic,extra} to
> x11-fonts/noto-sans-symbols
> - Merge x11-fonts/noto-serif-{basic,extra} to x11-fonts/noto-serif
> - Update x11-fonts/noto-basic to depend on the 4 merged ports
> - Update x11-fonts/noto-extra by removing the 4 -extra ports from
> RUN_DEPENDS
>=20
> [1] https://people.freebsd.org/~sunpoet/patch/noto.txt
Changes to x11-fonts/noto-sans and x11-fonts/noto-serif seem to be missing.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20240419130529.6068bc4b>