From owner-svn-src-vendor@freebsd.org Thu Oct 15 15:44:12 2015 Return-Path: Delivered-To: svn-src-vendor@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 745A5A1581B; Thu, 15 Oct 2015 15:44:12 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id C994BFC; Thu, 15 Oct 2015 15:44:10 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA05522; Thu, 15 Oct 2015 18:44:09 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1ZmkhM-000MNr-S1; Thu, 15 Oct 2015 18:44:08 +0300 Subject: Re: svn commit: r289310 - vendor-sys/illumos/dist/common/zfs vendor-sys/illumos/dist/uts/common vendor-sys/illumos/dist/uts/common/crypto vendor-sys/illumos/dist/uts/common/crypto/io vendor-sys/illumos... To: Alexander Motin , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-vendor@FreeBSD.org References: <201510141112.t9EBCmFZ022230@repo.freebsd.org> <561FC5A0.3040909@FreeBSD.org> <561FC90F.4090706@FreeBSD.org> From: Andriy Gapon Message-ID: <561FC996.3020207@FreeBSD.org> Date: Thu, 15 Oct 2015 17:43:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <561FC90F.4090706@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-vendor@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the vendor work area tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2015 15:44:12 -0000 On 15/10/2015 17:41, Alexander Motin wrote: > On 15.10.2015 18:26, Andriy Gapon wrote: >> On 14/10/2015 13:12, Alexander Motin wrote: >>> Author: mav >>> Date: Wed Oct 14 11:12:47 2015 >>> New Revision: 289310 >>> URL: https://svnweb.freebsd.org/changeset/base/289310 >>> >>> Log: >>> 4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R >>> >>> Reviewed by: George Wilson >>> Reviewed by: Prakash Surya >>> Reviewed by: Saso Kiselkov >>> Reviewed by: Richard Lowe >>> Approved by: Garrett D'Amore >>> Author: Matthew Ahrens >>> >>> illumos/illumos-gate@45818ee124adeaaf947698996b4f4c722afc6d1f >>> >>> Added: >>> vendor/illumos/dist/common/crypto/ >>> vendor/illumos/dist/common/crypto/edonr/ >>> vendor/illumos/dist/common/crypto/edonr/edonr.c (contents, props changed) >>> vendor/illumos/dist/common/crypto/edonr/edonr_byteorder.h (contents, props changed) >>> vendor/illumos/dist/common/crypto/skein/ >>> vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE (contents, props changed) >>> vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE.descrip (contents, props changed) >>> vendor/illumos/dist/common/crypto/skein/skein.c (contents, props changed) >>> vendor/illumos/dist/common/crypto/skein/skein_block.c (contents, props changed) >>> vendor/illumos/dist/common/crypto/skein/skein_impl.h (contents, props changed) >>> vendor/illumos/dist/common/crypto/skein/skein_iv.c (contents, props changed) >>> vendor/illumos/dist/common/crypto/skein/skein_port.h (contents, props changed) >> >> It seems that these are pieces of code that can be used by both the >> userland and the kernel. I think that previously we used to import such >> code into illumos-sys and then integrate it into sys/cddl (e.g. >> common/zfs/). Perhaps it is worthwhile following that convention in >> this case as well? > > I haven't decided what to do with this specific case. As I understand, > now we are using FreeBSD's native crypto code instead of illumos' one. I > was thinking about importing this commit only in infrastructural parts, > until respective algorithms are implemented in our native crypto. I > think it should not be a problem for Skein, since according to comments > it is in public domain. About Edon-R I am not sure, since it seems to be > CDDL. > This is confusing... It seems that like you replied to my question in another email, not the quoted one :-) -- Andriy Gapon