From owner-cvs-all@FreeBSD.ORG  Mon Sep 29 16:04:55 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 51FD61065686;
	Mon, 29 Sep 2008 16:04:55 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:3fb::211])
	by mx1.freebsd.org (Postfix) with ESMTP id 1628B8FC13;
	Mon, 29 Sep 2008 16:04:55 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 5458C1CC50; Mon, 29 Sep 2008 18:04:54 +0200 (CEST)
Date: Mon, 29 Sep 2008 18:04:54 +0200
From: Ed Schouten <ed@80386.nl>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20080929160454.GE16837@hoeg.nl>
References: <200809281644.m8SGiNZD041087@repoman.freebsd.org>
	<200809291051.47759.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ILuaRSyQpoVaJ1HG"
Content-Disposition: inline
In-Reply-To: <200809291051.47759.jhb@freebsd.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/bin/pkill pkill.1 pkill.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Sep 2008 16:04:55 -0000


--ILuaRSyQpoVaJ1HG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* John Baldwin <jhb@freebsd.org> wrote:
> On Sunday 28 September 2008 12:44:15 pm Ed Schouten wrote:
> > ed          2008-09-28 16:44:15 UTC
> >=20
> >   FreeBSD src repository
> >=20
> >   Modified files:
> >     bin/pkill            pkill.1 pkill.c=20
> >   Log:
> >   SVN rev 183438 on 2008-09-28 16:44:15Z by ed
> >  =20
> >   Don't automatically prepend the "tty" prefix to `pkill -t' arguments.
> >  =20
> >   Because we now enforce UNIX98-style PTY's, we now use a lot of TTY's
> >   that don't have the traditional /dev/ttyXX naming scheme. pkill(1)'s =
-t
> >   flag automatically prepended the word "tty" to each TTY that was pass=
ed
> >   on the command line. This meant that `pkill -t pts/0' was actually
> >   converted to /dev/ttypts/0. Disable this broken behaviour for now.
> >  =20
> >   Reported by:    erwin
>=20
> Why not fix it to do what other utilities like ps, etc. do and just try i=
t=20
> both ways?  You want to be able to use the 'tty' column from ps output as=
 an=20
> argument this, and serial port logins are still going to show up as 'd0'=
=20
> (sio0) or 'u0' (uart0).

Yeah, that's true. My fix was the best I could do in 5 minutes, but
trying both device names would seem like a fair approach. I'll see if I
can get to something this evening.

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--ILuaRSyQpoVaJ1HG
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkjg/KYACgkQ52SDGA2eCwVyagCcCEQCudl/UYIQcyw0GtybJMZb
iq8Anj2WaIl7inyB6QY6UIH+pxzwo+nt
=md6q
-----END PGP SIGNATURE-----

--ILuaRSyQpoVaJ1HG--