Date: Fri, 5 Feb 2016 11:54:39 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r408262 - head/editors/uemacs Message-ID: <56B4FDFF.1040308@FreeBSD.org> In-Reply-To: <56B4FD92.9080504@marino.st> References: <201602051859.u15IxnEx021230@repo.freebsd.org> <56B4FC78.6050005@FreeBSD.org> <56B4FD92.9080504@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IFSvxA6iaXe3h1DDcpu8oR5t5IGXCccAF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2/5/2016 11:52 AM, John Marino wrote: > On 2/5/2016 8:48 PM, Bryan Drewery wrote: >> On 2/5/2016 10:59 AM, John Marino wrote: >>> Author: marino >>> Date: Fri Feb 5 18:59:49 2016 >>> New Revision: 408262 >>> URL: https://svnweb.freebsd.org/changeset/ports/408262 >>> >>> Log: >>> editors/uemacs: document ncurses rqmt (USES+=3Dncurses), respect LD= FLAGS >>> =20 >>> Also link with ncurses, not termcap >>> =20 >>> approved by: infrastructure blanket >>> >>> Modified: >>> head/editors/uemacs/Makefile >>> >>> Modified: head/editors/uemacs/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/editors/uemacs/Makefile Fri Feb 5 18:57:54 2016 (r408261) >>> +++ head/editors/uemacs/Makefile Fri Feb 5 18:59:49 2016 (r408262) >>> @@ -13,10 +13,12 @@ COMMENT=3D Full screen editor >>> NO_CDROM=3D Resale allowed for media cost only >>> =20 >>> NO_WRKSUBDIR=3D yes >>> -USES=3D dos2unix zip >>> +USES=3D dos2unix ncurses zip >>> EXTRACT_BEFORE_ARGS=3D -Lq >>> =20 >>> post-patch: >>> @${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/src/*.c >>> + @${REINPLACE_CMD} -e 's|-ltermcap|${LDFLAGS} -lncurses|g' \ >>> + ${WRKSRC}/freebsd/makefile >>> =20 >>> .include <bsd.port.mk> >>> >> >> lrwxr-xr-x 1 root wheel 13 Mar 27 2015 /usr/lib/libtermcap.so@ -> >> libncurses.so >> >> libtermcap is symlinked to libncurses. Why is it worth maintaining ext= ra >> code to link to ncurses directly? >> >=20 > Libtermcap does not exist in ports, it's not in devel/ncurses. > If one wants doesn't want to use base, the port can't be built. The > obvious solution is make everythink link with libncurses so both base > and ports options are supported. >=20 >=20 Ok. The massive symlinking to ncurses in base bothers me as it creates issues for build dependencies for me. I have considered trying to eliminate them but haven't gone forward with it since it would break too much. --=20 Regards, Bryan Drewery --IFSvxA6iaXe3h1DDcpu8oR5t5IGXCccAF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWtP3/AAoJEDXXcbtuRpfPAU4H/ROSCCfzDEENK3KkIUJ5omBq eEHcYbIk1uNxtgnEynjcJFhxvhOHrvsoqf74eP+ioLrjO1cGPkxIXMHYxsSuLXAa P6c6lQsREufsypEZEK4A2fGQ5K24mNmAPS1LtIeolu5pz8kJXBorycpjx461PP/Z kGq5cXy4t/h1Vm25uFgtgrBpYhtMVS59FEDe7l6jSYIBdfkX/I9cdnGEiAZJE8pn VCbR4XyGrPnZ1SDIlVdWWt3EX2VdG5waDalkCWbU8aAkHnvoLFZB+btPu3mVI72u Q7cIwNRrcivlEvO1fGjicB+GTI882qubRE0rxkDX1PQ64fLElvG/Mb7MrvXXM4o= =v/oP -----END PGP SIGNATURE----- --IFSvxA6iaXe3h1DDcpu8oR5t5IGXCccAF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56B4FDFF.1040308>