From owner-freebsd-net@FreeBSD.ORG  Fri Sep  8 11:03:14 2006
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2CE7816A4DE;
	Fri,  8 Sep 2006 11:03:14 +0000 (UTC)
	(envelope-from if@hetzner.co.za)
Received: from hetzner.co.za (office.cpt2.host-h.net [196.7.147.230])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3E84643D55;
	Fri,  8 Sep 2006 11:03:13 +0000 (GMT)
	(envelope-from if@hetzner.co.za)
Received: from localhost ([127.0.0.1] helo=ian.hetzner.africa)
	by hetzner.co.za with esmtp (Exim 4.62 (FreeBSD))
	(envelope-from <if@hetzner.co.za>)
	id 1GLe8a-000In3-6a; Fri, 08 Sep 2006 13:03:08 +0200
To: Andre Oppermann <andre@freebsd.org>
From: Ian FREISLICH <if@hetzner.co.za>
In-Reply-To: Message from Andre Oppermann <andre@freebsd.org> 
	of "Thu, 07 Sep 2006 16:02:01 +0200." <45002659.9050203@freebsd.org> 
X-Attribution: BOFH
Date: Fri, 08 Sep 2006 13:03:08 +0200
Message-Id: <E1GLe8a-000In3-6a@hetzner.co.za>
Cc: freebsd-net <freebsd-net@freebsd.org>,
	freebsd-current <freebsd-current@freebsd.org>,
	Jack Vogel <jfvogel@gmail.com>
Subject: Re: RFC: TSO patch for current 
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Sep 2006 11:03:14 -0000

Andre Oppermann wrote:
> Jack Vogel wrote:
> > On 9/5/06, Andre Oppermann <andre@freebsd.org> wrote:
> >> > If you do the ifconfig changes there will need to be a small amount of
> >> > code added to em_ioctl() but it should be trivial.
> >> >
> >> > You want me to reissue a driver patch with changes for your code?
> >>
> >> Yes, please do so.  I've got a dual-em card which I can test with myself.
> > 
> > OK, attached new patch, this one even has the ioctl change so when
> > you get the ifconfig change in it will be ready.
>
> The TSO code is committed.  There has been a slight change with the
> ifcapabilities to differentiate between TSO for IPv4 and IPv6 which
> can be set independently.
>
> The pseudo-header checksum is always provided in m_pkthdr.csum_data,
> you don't have to compute it yourself in the driver.
>
> TSO for IPv6 is not yet functional as it is missing the in6_pseudo()
> functionand some changes to ip6_output().  I have contacted one of our
> IPv6 gurus to develop the patches and get it fully functional as well.

Since this change, I get the following output from ifconfig:
em0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
        options=cb<RXCSUM,TXCSUM,VLAN_MTU,POLLING8TSO49TSO6,VLAN_HWCSUM>
        ether 00:04:23:d4:74:46
        media: Ethernet autoselect (1000baseTX <full-duplex>)
        status: active

If I disable polling:
em0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
        options=8b<RXCSUM,TXCSUM,VLAN_MTU,VLAN_HWCSUM>
        ether 00:04:23:d4:74:46
        media: Ethernet autoselect (1000baseTX <full-duplex>)

I'm not sure if this hardware supports TSO or even if the em driver
part has been committed yet.

Ian

--
Ian Freislich