From owner-freebsd-current@FreeBSD.ORG Mon Nov 15 11:29:48 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 900A716A4CE; Mon, 15 Nov 2004 11:29:48 +0000 (GMT) Received: from mailout09.sul.t-online.com (mailout09.sul.t-online.com [194.25.134.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id E06BA43D1F; Mon, 15 Nov 2004 11:29:47 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from fwd06.aul.t-online.de by mailout09.sul.t-online.com with smtp id 1CTf3K-0006uR-03; Mon, 15 Nov 2004 12:29:46 +0100 Received: from Andro-Beta.Leidinger.net (JJrXxZZLZeskW3WCXaoqQn7x5ChCTSLbtqz5sRGhZaktEw2hYhNCro@[84.128.192.148]) by fmrl06.sul.t-online.com with esmtp id 1CTf36-0sUQsK0; Mon, 15 Nov 2004 12:29:32 +0100 Received: from Andro-Beta.Leidinger.net (localhost [127.0.0.1]) iAFBTqfp067600; Mon, 15 Nov 2004 12:29:52 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: (from www@localhost)iAFBTqAF067599; Mon, 15 Nov 2004 12:29:52 +0100 (CET) (envelope-from Alexander@Leidinger.net) X-Authentication-Warning: Andro-Beta.Leidinger.net: www set sender to Alexander@Leidinger.net using -f Received: from 141.113.101.32 ([141.113.101.32]) by netchild.homeip.net (IMP) with HTTP for ; Mon, 15 Nov 2004 12:29:51 +0100 Message-ID: <1100518191.4198932fc1dd4@netchild.homeip.net> Date: Mon, 15 Nov 2004 12:29:51 +0100 From: Alexander Leidinger To: Harti Brandt , knu@freebsd.org References: <6857.1100271323@critter.freebsd.dk> <20041112160137.X42945@beagle.kn.op.dlr.de> <1100274897.4194dcd1d67d6@netchild.homeip.net> <20041112171024.P42945@beagle.kn.op.dlr.de> <20041113092215.7a40f133@Magellan.Leidinger.net> <20041115091059.L51863@beagle.kn.op.dlr.de> In-Reply-To: <20041115091059.L51863@beagle.kn.op.dlr.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.2.6 / FreeBSD-4.10 X-Originating-IP: 141.113.101.32 X-ID: JJrXxZZLZeskW3WCXaoqQn7x5ChCTSLbtqz5sRGhZaktEw2hYhNCro@t-dialin.net X-TOI-MSGID: b4d4bf4f-b8dc-4fdd-99c2-c36f5ebf9cf3 cc: Poul-Henning Kamp cc: current@freebsd.org Subject: Re: [TEST] make -j patch [take 2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2004 11:29:48 -0000 Zitat von Harti Brandt : [knu CCed because he should know how portupgrade operates :-)] > Unless you reset MAKEFLAGS along the call path to the portupgrade's make > they'll see the -j, because the top-level make will stuff the -j into > MAKEFLAGS and that is probably inherited through portupgrade. I don't know how ruby handles exec()ing of external programs, but unless it inherits the environment by default, portupgrade doesn't seems to inherit MAKEFLAGS ("grep MAKEFLAGS /usr/local/lib/ruby/site_ruby/1.8/* /usr/local/sbin/port*" shows no hits). So if portupgrade inherits MAKEFLAGS somehow, phk's patch shouldn't cause unexpected harm in this szenario, if portupgrade doesn't inherit MAKEFLAGS, his patch violates POLA in this case. Bye, Alexander. -- http://www.Leidinger.net/ Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org/ netchild @ FreeBSD.org : PGP ID = 72077137