Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Jun 2020 21:16:01 -0700
From:      Craig Leres <leres@freebsd.org>
To:        Jan Beich <jbeich@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r539972 - in head: Mk www/firefox www/firefox/files
Message-ID:  <2faeb9bb-2fcd-8921-d007-cc332ca28af7@freebsd.org>
In-Reply-To: <202006231148.05NBmd2q076597@repo.freebsd.org>
References:  <202006231148.05NBmd2q076597@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------6EB83D3F208FF5A39E6909F2
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 2020-06-23 04:48, Jan Beich wrote:
> Author: jbeich
> Date: Tue Jun 23 11:48:39 2020
> New Revision: 539972
> URL: https://svnweb.freebsd.org/changeset/ports/539972
> 
> Log:
>   www/firefox: update to 78.0

This version doesn't build for me (11.3-RELEASE-p10 and my options are
appended):


/wrkdirs/usr/ports/www/firefox/work/firefox-78.0/mozglue/baseprofiler/core/shared-libraries-linux.cc:377:34:
error:
          use of undeclared identifier 'NT_GNU_BUILD_ID'
          if (note_header->n_type == NT_GNU_BUILD_ID) break;

I can see NT_GNU_BUILD_ID being defined in
mozglue/baseprofiler/lul/LulElfInt.h but only when GP_OS_android is
defined. A few other module have the same issue; I worked around with
the ifdef in the attached patches.

		Craig

zinc 501 # fgrep _SET
/usr/local/etc/poudriere.d/current-patched-options/www_firefox/options
OPTIONS_FILE_SET+=DBUS
OPTIONS_FILE_SET+=FFMPEG
OPTIONS_FILE_SET+=OPTIMIZED_CFLAGS
OPTIONS_FILE_SET+=ALSA

--------------6EB83D3F208FF5A39E6909F2
Content-Type: text/plain; charset=UTF-8;
 name="patch-mozglue_baseprofiler_core_shared-libraries-linux.cc"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename*0="patch-mozglue_baseprofiler_core_shared-libraries-linux.cc"

LS0tIG1vemdsdWUvYmFzZXByb2ZpbGVyL2NvcmUvc2hhcmVkLWxpYnJhcmllcy1saW51eC5j
Yy5vcmlnCTIwMjAtMDYtMjUgMDI6NDU6MDIgVVRDCisrKyBtb3pnbHVlL2Jhc2Vwcm9maWxl
ci9jb3JlL3NoYXJlZC1saWJyYXJpZXMtbGludXguY2MKQEAgLTM3MSw3ICszNzEsOSBAQCBj
bGFzcyBGaWxlSUQgewogICAgIGNvbnN0IHZvaWQqIHNlY3Rpb25fZW5kID0gcmVpbnRlcnBy
ZXRfY2FzdDxjb25zdCBjaGFyKj4oc2VjdGlvbikgKyBsZW5ndGg7CiAgICAgY29uc3QgTmhk
ciogbm90ZV9oZWFkZXIgPSByZWludGVycHJldF9jYXN0PGNvbnN0IE5oZHIqPihzZWN0aW9u
KTsKICAgICB3aGlsZSAocmVpbnRlcnByZXRfY2FzdDxjb25zdCB2b2lkKj4obm90ZV9oZWFk
ZXIpIDwgc2VjdGlvbl9lbmQpIHsKKyNpZmRlZiBOVF9HTlVfQlVJTERfSUQKICAgICAgIGlm
IChub3RlX2hlYWRlci0+bl90eXBlID09IE5UX0dOVV9CVUlMRF9JRCkgYnJlYWs7CisjZW5k
aWYKICAgICAgIG5vdGVfaGVhZGVyID0gcmVpbnRlcnByZXRfY2FzdDxjb25zdCBOaGRyKj4o
CiAgICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4obm90ZV9oZWFkZXIp
ICsgc2l6ZW9mKE5oZHIpICsKICAgICAgICAgICBOT1RFX1BBRERJTkcobm90ZV9oZWFkZXIt
Pm5fbmFtZXN6KSArCg==
--------------6EB83D3F208FF5A39E6909F2
Content-Type: text/plain; charset=UTF-8;
 name="patch-mozglue_baseprofiler_lul_LulElf.cpp"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="patch-mozglue_baseprofiler_lul_LulElf.cpp"

LS0tIG1vemdsdWUvYmFzZXByb2ZpbGVyL2x1bC9MdWxFbGYuY3BwLm9yaWcJMjAyMC0wNi0y
NSAwMzoxMDoxMCBVVEMKKysrIG1vemdsdWUvYmFzZXByb2ZpbGVyL2x1bC9MdWxFbGYuY3Bw
CkBAIC03NTksNyArNzU5LDkgQEAgc3RhdGljIGJvb2wgRWxmQ2xhc3NCdWlsZElETm90ZUlk
ZW50aWZpZQogICBjb25zdCB2b2lkKiBzZWN0aW9uX2VuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8
Y29uc3QgY2hhcio+KHNlY3Rpb24pICsgbGVuZ3RoOwogICBjb25zdCBOaGRyKiBub3RlX2hl
YWRlciA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTmhkcio+KHNlY3Rpb24pOwogICB3aGls
ZSAocmVpbnRlcnByZXRfY2FzdDxjb25zdCB2b2lkKj4obm90ZV9oZWFkZXIpIDwgc2VjdGlv
bl9lbmQpIHsKKyNpZmRlZiBOVF9HTlVfQlVJTERfSUQKICAgICBpZiAobm90ZV9oZWFkZXIt
Pm5fdHlwZSA9PSBOVF9HTlVfQlVJTERfSUQpIGJyZWFrOworI2VuZGlmCiAgICAgbm90ZV9o
ZWFkZXIgPSByZWludGVycHJldF9jYXN0PGNvbnN0IE5oZHIqPigKICAgICAgICAgcmVpbnRl
cnByZXRfY2FzdDxjb25zdCBjaGFyKj4obm90ZV9oZWFkZXIpICsgc2l6ZW9mKE5oZHIpICsK
ICAgICAgICAgTk9URV9QQURESU5HKG5vdGVfaGVhZGVyLT5uX25hbWVzeikgKwo=
--------------6EB83D3F208FF5A39E6909F2
Content-Type: text/plain; charset=UTF-8;
 name="patch-tools_profiler_lul_LulElf.cpp"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="patch-tools_profiler_lul_LulElf.cpp"

LS0tIHRvb2xzL3Byb2ZpbGVyL2x1bC9MdWxFbGYuY3BwLm9yaWcJMjAyMC0wNi0yNSAwMzo1
MjowOCBVVEMKKysrIHRvb2xzL3Byb2ZpbGVyL2x1bC9MdWxFbGYuY3BwCkBAIC03NzMsNyAr
NzczLDkgQEAgc3RhdGljIGJvb2wgRWxmQ2xhc3NCdWlsZElETm90ZUlkZW50aWZpZQogICBj
b25zdCB2b2lkKiBzZWN0aW9uX2VuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+
KHNlY3Rpb24pICsgbGVuZ3RoOwogICBjb25zdCBOaGRyKiBub3RlX2hlYWRlciA9IHJlaW50
ZXJwcmV0X2Nhc3Q8Y29uc3QgTmhkcio+KHNlY3Rpb24pOwogICB3aGlsZSAocmVpbnRlcnBy
ZXRfY2FzdDxjb25zdCB2b2lkKj4obm90ZV9oZWFkZXIpIDwgc2VjdGlvbl9lbmQpIHsKKyNp
ZmRlZiBOVF9HTlVfQlVJTERfSUQKICAgICBpZiAobm90ZV9oZWFkZXItPm5fdHlwZSA9PSBO
VF9HTlVfQlVJTERfSUQpIGJyZWFrOworI2VuZGlmCiAgICAgbm90ZV9oZWFkZXIgPSByZWlu
dGVycHJldF9jYXN0PGNvbnN0IE5oZHIqPigKICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxj
b25zdCBjaGFyKj4obm90ZV9oZWFkZXIpICsgc2l6ZW9mKE5oZHIpICsKICAgICAgICAgTk9U
RV9QQURESU5HKG5vdGVfaGVhZGVyLT5uX25hbWVzeikgKwo=
--------------6EB83D3F208FF5A39E6909F2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2faeb9bb-2fcd-8921-d007-cc332ca28af7>