From owner-svn-ports-all@freebsd.org Thu Jun 25 04:16:04 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 64BAA34EFDF; Thu, 25 Jun 2020 04:16:04 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49smsc224xz4Whk; Thu, 25 Jun 2020 04:16:04 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from ice.alameda.xse.com (unknown [IPv6:2600:1700:a570:11f0:f2ad:4eff:fe0b:a065]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: leres) by smtp.freebsd.org (Postfix) with ESMTPSA id AC3EA27901; Thu, 25 Jun 2020 04:16:03 +0000 (UTC) (envelope-from leres@freebsd.org) Subject: Re: svn commit: r539972 - in head: Mk www/firefox www/firefox/files To: Jan Beich , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202006231148.05NBmd2q076597@repo.freebsd.org> From: Craig Leres Autocrypt: addr=leres@freebsd.org; keydata= mQENBFmzIBcBCADDnzsYSnfD4LAEy1CF4ZTarerhpKv+mzz4b1UksikPdA+Ji+YQcnq1++Xp 2iSF/rukKCu8xMJHBFWnWvEyFCAvtMF89HsRF/uml4wPPnLLoVRBu8GHv/7WDI/5C2q4Gw5b Qqxti3/uxC0E84sd1S1dP+bOQngH/r6ndh1KEzXDFmMA82uzcn3v3+YfXqDEcKP9R6c2UZ36 HBKlqNZCLzXVtKuPGWGh5Qq3LHMbqGxEtFICjOIUIHIU4tA+H8ei++olktYy1rYKiqxUu5zf aMh1fNXNvMt1VawYw0LDbJIATpVoOw8anMvdYgGJqp26wqCQ2eGMINIJ4XgckRFsfpErABEB AAG0H0NyYWlnIExlcmVzIDxsZXJlc0BmcmVlYnNkLm9yZz6JAVQEEwEIAD4WIQSnVCNkUge5 ZCAWF+HmoS0S/L+F5QUCWbMhOQIbAwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAK CRDmoS0S/L+F5Q4cCACGbtFm9whfNy0llkOLM9JNvtTaF792u0AmGIC50vs2Zx+sUIukL+T6 /G8/AB0LhqCobRj810UlqVPpD87JmFvE5G15HfuJ/4HgNPl60s8gFHqDQkzAbzetd8dmpGER c7LFrwgRLS7m8KmRaGHI8U6Mt6HVsWJPt1qlFifGixXod+6T4wvsoB1QyZp/804EmkQxSWPJ cJxhWrWtcAKBD87pR+evAjMFNlqIwOw4yEGHN1qPxppqf1Z3hBwIDabH+AUA3eeGdFRnXwDX jymaflbce90CQvX7IF67jV6q9bD/7zuR+pYclQnzUWgFpnRgCapiNThJTChRNRDOGYquGOgh uQENBFmzIBcBCADMUffip39kCoC42OIceIRnEw42raLkkinaLy5QC4+fQsOom2BFUaCF5ZnF kOV22cI4x1pfluNfJzd4OKP5t1D4Obc4h5zjyYDCViCiTRnM0Le1CV79WC1GFHuf1MgJJ2rf RY35nJInlnG8KCJnE/Q9Dd1S19/kr7Qt9NZb3RaGwPMFB0X2NTgtdYz3kz+O+eexanbGw9lI FvjZQEtPwsfzl7mrM4jpCt/S+b/Xupg9WzKVVrIVrBeZnSi7z1wcMhc6yZIJQJg1tRfVJ4Dl B3H8hQA/6STf78J//B10vj3QlxbPj6oXpRtQcuD2969+BsL6CGGz3tkuDSLuwweIRpnbABEB AAGJATwEGAEIACYWIQSnVCNkUge5ZCAWF+HmoS0S/L+F5QUCWbMgFwIbDAUJBaOagAAKCRDm oS0S/L+F5XfdB/4sHhMseAG6TovPFWjoMnsRFBv1dR1GjO7Ms+1577Lqlwe2lGDFGE3f1rgZ 98G23qiWnm8mmWY5NT8yJfkOgfDGNYh2obSYWBUALCvespU0rvut96ALnnutVcXUmRkPpuTH 8UqTOyWKMaj6DoFzRBWJ8SZg5bfEhdlwQdLN6iRNHUt3/NjCwkPZszr/QL+ZpCeGSXj68V8l kS//sIeXJdFQ8EZT0eQCy5mYXhKhGDxF5yOkVjCiKBGh7UnJhUCZ3iDVoH28ZQtSijhAIpsD XuEgCHKVgATKZ4+aWscWUqpbgo+3EK75VR9VzAo7LDlZ7RsFtmv1kzELmleCJNNeByKW Message-ID: <2faeb9bb-2fcd-8921-d007-cc332ca28af7@freebsd.org> Date: Wed, 24 Jun 2020 21:16:01 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <202006231148.05NBmd2q076597@repo.freebsd.org> Content-Type: multipart/mixed; boundary="------------6EB83D3F208FF5A39E6909F2" Content-Language: en-US X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2020 04:16:04 -0000 This is a multi-part message in MIME format. --------------6EB83D3F208FF5A39E6909F2 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 2020-06-23 04:48, Jan Beich wrote: > Author: jbeich > Date: Tue Jun 23 11:48:39 2020 > New Revision: 539972 > URL: https://svnweb.freebsd.org/changeset/ports/539972 > > Log: > www/firefox: update to 78.0 This version doesn't build for me (11.3-RELEASE-p10 and my options are appended): /wrkdirs/usr/ports/www/firefox/work/firefox-78.0/mozglue/baseprofiler/core/shared-libraries-linux.cc:377:34: error: use of undeclared identifier 'NT_GNU_BUILD_ID' if (note_header->n_type == NT_GNU_BUILD_ID) break; I can see NT_GNU_BUILD_ID being defined in mozglue/baseprofiler/lul/LulElfInt.h but only when GP_OS_android is defined. A few other module have the same issue; I worked around with the ifdef in the attached patches. Craig zinc 501 # fgrep _SET /usr/local/etc/poudriere.d/current-patched-options/www_firefox/options OPTIONS_FILE_SET+=DBUS OPTIONS_FILE_SET+=FFMPEG OPTIONS_FILE_SET+=OPTIMIZED_CFLAGS OPTIONS_FILE_SET+=ALSA --------------6EB83D3F208FF5A39E6909F2 Content-Type: text/plain; charset=UTF-8; name="patch-mozglue_baseprofiler_core_shared-libraries-linux.cc" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="patch-mozglue_baseprofiler_core_shared-libraries-linux.cc" LS0tIG1vemdsdWUvYmFzZXByb2ZpbGVyL2NvcmUvc2hhcmVkLWxpYnJhcmllcy1saW51eC5j Yy5vcmlnCTIwMjAtMDYtMjUgMDI6NDU6MDIgVVRDCisrKyBtb3pnbHVlL2Jhc2Vwcm9maWxl ci9jb3JlL3NoYXJlZC1saWJyYXJpZXMtbGludXguY2MKQEAgLTM3MSw3ICszNzEsOSBAQCBj bGFzcyBGaWxlSUQgewogICAgIGNvbnN0IHZvaWQqIHNlY3Rpb25fZW5kID0gcmVpbnRlcnBy ZXRfY2FzdDxjb25zdCBjaGFyKj4oc2VjdGlvbikgKyBsZW5ndGg7CiAgICAgY29uc3QgTmhk ciogbm90ZV9oZWFkZXIgPSByZWludGVycHJldF9jYXN0PGNvbnN0IE5oZHIqPihzZWN0aW9u KTsKICAgICB3aGlsZSAocmVpbnRlcnByZXRfY2FzdDxjb25zdCB2b2lkKj4obm90ZV9oZWFk ZXIpIDwgc2VjdGlvbl9lbmQpIHsKKyNpZmRlZiBOVF9HTlVfQlVJTERfSUQKICAgICAgIGlm IChub3RlX2hlYWRlci0+bl90eXBlID09IE5UX0dOVV9CVUlMRF9JRCkgYnJlYWs7CisjZW5k aWYKICAgICAgIG5vdGVfaGVhZGVyID0gcmVpbnRlcnByZXRfY2FzdDxjb25zdCBOaGRyKj4o CiAgICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4obm90ZV9oZWFkZXIp ICsgc2l6ZW9mKE5oZHIpICsKICAgICAgICAgICBOT1RFX1BBRERJTkcobm90ZV9oZWFkZXIt Pm5fbmFtZXN6KSArCg== --------------6EB83D3F208FF5A39E6909F2 Content-Type: text/plain; charset=UTF-8; name="patch-mozglue_baseprofiler_lul_LulElf.cpp" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch-mozglue_baseprofiler_lul_LulElf.cpp" LS0tIG1vemdsdWUvYmFzZXByb2ZpbGVyL2x1bC9MdWxFbGYuY3BwLm9yaWcJMjAyMC0wNi0y NSAwMzoxMDoxMCBVVEMKKysrIG1vemdsdWUvYmFzZXByb2ZpbGVyL2x1bC9MdWxFbGYuY3Bw CkBAIC03NTksNyArNzU5LDkgQEAgc3RhdGljIGJvb2wgRWxmQ2xhc3NCdWlsZElETm90ZUlk ZW50aWZpZQogICBjb25zdCB2b2lkKiBzZWN0aW9uX2VuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8 Y29uc3QgY2hhcio+KHNlY3Rpb24pICsgbGVuZ3RoOwogICBjb25zdCBOaGRyKiBub3RlX2hl YWRlciA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgTmhkcio+KHNlY3Rpb24pOwogICB3aGls ZSAocmVpbnRlcnByZXRfY2FzdDxjb25zdCB2b2lkKj4obm90ZV9oZWFkZXIpIDwgc2VjdGlv bl9lbmQpIHsKKyNpZmRlZiBOVF9HTlVfQlVJTERfSUQKICAgICBpZiAobm90ZV9oZWFkZXIt Pm5fdHlwZSA9PSBOVF9HTlVfQlVJTERfSUQpIGJyZWFrOworI2VuZGlmCiAgICAgbm90ZV9o ZWFkZXIgPSByZWludGVycHJldF9jYXN0PGNvbnN0IE5oZHIqPigKICAgICAgICAgcmVpbnRl cnByZXRfY2FzdDxjb25zdCBjaGFyKj4obm90ZV9oZWFkZXIpICsgc2l6ZW9mKE5oZHIpICsK ICAgICAgICAgTk9URV9QQURESU5HKG5vdGVfaGVhZGVyLT5uX25hbWVzeikgKwo= --------------6EB83D3F208FF5A39E6909F2 Content-Type: text/plain; charset=UTF-8; name="patch-tools_profiler_lul_LulElf.cpp" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch-tools_profiler_lul_LulElf.cpp" LS0tIHRvb2xzL3Byb2ZpbGVyL2x1bC9MdWxFbGYuY3BwLm9yaWcJMjAyMC0wNi0yNSAwMzo1 MjowOCBVVEMKKysrIHRvb2xzL3Byb2ZpbGVyL2x1bC9MdWxFbGYuY3BwCkBAIC03NzMsNyAr NzczLDkgQEAgc3RhdGljIGJvb2wgRWxmQ2xhc3NCdWlsZElETm90ZUlkZW50aWZpZQogICBj b25zdCB2b2lkKiBzZWN0aW9uX2VuZCA9IHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+ KHNlY3Rpb24pICsgbGVuZ3RoOwogICBjb25zdCBOaGRyKiBub3RlX2hlYWRlciA9IHJlaW50 ZXJwcmV0X2Nhc3Q8Y29uc3QgTmhkcio+KHNlY3Rpb24pOwogICB3aGlsZSAocmVpbnRlcnBy ZXRfY2FzdDxjb25zdCB2b2lkKj4obm90ZV9oZWFkZXIpIDwgc2VjdGlvbl9lbmQpIHsKKyNp ZmRlZiBOVF9HTlVfQlVJTERfSUQKICAgICBpZiAobm90ZV9oZWFkZXItPm5fdHlwZSA9PSBO VF9HTlVfQlVJTERfSUQpIGJyZWFrOworI2VuZGlmCiAgICAgbm90ZV9oZWFkZXIgPSByZWlu dGVycHJldF9jYXN0PGNvbnN0IE5oZHIqPigKICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxj b25zdCBjaGFyKj4obm90ZV9oZWFkZXIpICsgc2l6ZW9mKE5oZHIpICsKICAgICAgICAgTk9U RV9QQURESU5HKG5vdGVfaGVhZGVyLT5uX25hbWVzeikgKwo= --------------6EB83D3F208FF5A39E6909F2--