Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Mar 2015 14:29:56 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>, Steve Wills <swills@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r382338 - head/devel/hub
Message-ID:  <E3EAEA54DF34CDAF07CE559F@ogg.in.absolight.net>
In-Reply-To: <CAMHz58T26zcDv6%2BHRpLRZ0odA019tKq0pVK3pxU4vFAFpDKW4Q@mail.gmail.com>
References:  <201503261933.t2QJXana047644@svn.freebsd.org> <CAMHz58T26zcDv6%2BHRpLRZ0odA019tKq0pVK3pxU4vFAFpDKW4Q@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
+--On 27 mars 2015 21:06:18 +0800 Sunpoet Po-Chuan Hsieh
<sunpoet@freebsd.org> wrote:
| On Fri, Mar 27, 2015 at 3:33 AM, Steve Wills <swills@freebsd.org> wrote:
| 
|> Author: swills
|> Date: Thu Mar 26 19:33:35 2015
|> New Revision: 382338
|> URL: https://svnweb.freebsd.org/changeset/ports/382338
|> QAT: https://qat.redports.org/buildarchive/r382338/
|> 
|> Log:
|>   devel/hub: update to 2.2.0
|> 
|>   PR:           197999
|>   Submitted by: swills (myself)
|>   Approved by:  koukopoulos@gmail.com (maintainer)
|> 
|> Modified:
|>   head/devel/hub/Makefile
|>   head/devel/hub/distinfo
|> 
|> Modified: head/devel/hub/Makefile
|> 
|> ========================================================================
|> ====== --- head/devel/hub/Makefile     Thu Mar 26 19:24:15 2015
|> (r382337) +++ head/devel/hub/Makefile     Thu Mar 26 19:33:35 2015
|> (r382338) @@ -2,7 +2,7 @@
|>  # $FreeBSD$
|> 
|>  PORTNAME=      hub
|> -PORTVERSION=   1.12.2
|> +PORTVERSION=   2.2.0
|>  CATEGORIES=    devel
|> 
|>  MAINTAINER=    koukopoulos@gmail.com
|> @@ -12,22 +12,27 @@ LICENSE=    MIT
|> 
|>  USE_GITHUB=    yes
|>  GH_ACCOUNT=    github
|> -GH_TAGNAME=    v${DISTVERSION}
|> -GH_COMMIT=     9016a39
|> 
|> -USE_RUBY=      yes
|> -USE_RAKE=      yes
|> +DISTVERSIONPREFIX=v
|> +
|> +MASTER_SITES=   GH
|> +
|> +BUILD_DEPENDS= go:${PORTSDIR}/lang/go \
|> +               bash:${PORTSDIR}/shells/bash
|> +
|> +WRKSRC=                ${WRKDIR}/${PORTNAME}-${PORTVERSION}
|> +
|> +STRIP=         # stripping can break go binaries
|> 
|>  PLIST_FILES=   bin/hub \
|>                 etc/bash_completion.d/hub \
|>                 share/zsh/site-functions/_hub \
|>                 man/man1/hub.1.gz
|> -
|>  do-build:
|> -       @cd ${WRKSRC} && ${RAKE_BIN} standalone
|> +       @cd ${WRKSRC} ; ${SETENV} ${LOCALBASE}/bin/bash script/build
|> 
|>  do-install:
|> -       ${INSTALL_SCRIPT} ${WRKSRC}/hub ${STAGEDIR}${PREFIX}/bin
|> +       ${INSTALL_PROGRAM} ${WRKSRC}/hub ${STAGEDIR}${PREFIX}/bin
|>         ${INSTALL_MAN} ${WRKSRC}/man/hub.1
|> ${STAGEDIR}${MAN1PREFIX}/man/man1
|>         @${MKDIR} ${STAGEDIR}${PREFIX}/etc/bash_completion.d
|>         ${INSTALL_DATA} ${WRKSRC}/etc/hub.bash_completion.sh
|> ${STAGEDIR}${PREFIX}/etc/bash_completion.d/hub
|> 
|> Modified: head/devel/hub/distinfo
|> 
|> ========================================================================
|> ====== --- head/devel/hub/distinfo     Thu Mar 26 19:24:15 2015
|> (r382337) +++ head/devel/hub/distinfo     Thu Mar 26 19:33:35 2015
|> (r382338) @@ -1,2 +1,2 @@
|> -SHA256 (hub-1.12.2.tar.gz) =
|> 98003caa613ae94fffd6611f1f3e9b58d906349d0579b8aca16f137cb13a5347
|> -SIZE (hub-1.12.2.tar.gz) = 76606
|> +SHA256 (hub-v2.2.0_GH0.tar.gz) =
|> 2da1351197eb5696c207f22c69a5422af052d74277b73d0b8661efb9ec1d0eb1
|> +SIZE (hub-v2.2.0_GH0.tar.gz) = 301460
|> 
|> 
| Hi Steve,
| 
| I have several suggestions:
| - With r382120, I think GH_TAGNAME=v${PORTVERSION} is better than
| DISTVERSIONPREFIX=v.
| - MASTER_SITES can be removed if github.com is the only master site.
| USE_GITHUB will handle it.
| - To pet portlint, move BUILD_DEPENDS after the LICENSE section.

To pet portlint, DISTVERSIONPREFIX should also be moved to the top block.
I still think using DISTVERSIONSPREFIX is better.

-- 
Mathieu Arnold



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E3EAEA54DF34CDAF07CE559F>