From owner-freebsd-stable Wed Oct 23 9:56:42 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4DA0837B404 for ; Wed, 23 Oct 2002 09:56:40 -0700 (PDT) Received: from wall.polstra.com (wall-gw.polstra.com [206.213.73.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 21C2743E6A for ; Wed, 23 Oct 2002 09:56:31 -0700 (PDT) (envelope-from jdp@polstra.com) Received: from vashon.polstra.com (vashon.polstra.com [206.213.73.13]) by wall.polstra.com (8.11.3/8.11.3) with ESMTP id g9NGuUx79023 for ; Wed, 23 Oct 2002 09:56:30 -0700 (PDT) (envelope-from jdp@vashon.polstra.com) Received: (from jdp@localhost) by vashon.polstra.com (8.12.5/8.12.5/Submit) id g9NGuRb7038435; Wed, 23 Oct 2002 09:56:27 -0700 (PDT) (envelope-from jdp) Date: Wed, 23 Oct 2002 09:56:27 -0700 (PDT) Message-Id: <200210231656.g9NGuRb7038435@vashon.polstra.com> To: stable@freebsd.org From: John Polstra Subject: Re: Where to send pam_radius feature request In-Reply-To: <3DB3C686.5000306@ntmk.ru> References: <3DB3C686.5000306@ntmk.ru> Organization: Polstra & Co., Seattle, WA Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In article <3DB3C686.5000306@ntmk.ru>, Boris Kovalenko wrote: > I have feature request for pam_radius module and have done dirty > patch for it. Please don't take this personally -- I didn't look at your patch and I don't mean to single you out. For all I know, your patch wasn't "dirty" at all. But I want to use this opportunity to point out that in general, sending a "dirty patch" to a committer is not a productive approach. It is easy to create a quick and dirty patch. What takes a lot of time is to turn it into a well-tested, clean, directly committable patch. If you send a committer a quick & dirty patch, it just creates a ton of work for the committer. I personally tend to let that kind of patch rot in my inbox until it falls off the bottom. I don't even feel guilty about it any more. If you send a committer a quick and dirty patch, you are taking all of the fun part for yourself and handing the drudge work to the committer. Sorry, but you have to pay me a whole lot of money to accept that arrangement. If you want me to do something for free, it had better be either fun or very easy. :-) If you really want something to get committed, do _all_ of the work to make it into a top-quality piece of work. Fix the style bugs. Update the documentation. Test it thoroughly. Explain how it works and why it works. Make the committer's job as easy as possible, if you want results. Just a friendly suggestion. John -- John Polstra John D. Polstra & Co., Inc. Seattle, Washington USA "Disappointment is a good sign of basic intelligence." -- Chögyam Trungpa To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message