From owner-freebsd-java Mon Jan 28 0:36:31 2002 Delivered-To: freebsd-java@freebsd.org Received: from zaphod.euronet.nl (zaphod.euronet.nl [194.134.128.241]) by hub.freebsd.org (Postfix) with ESMTP id 2B41637B400; Mon, 28 Jan 2002 00:36:26 -0800 (PST) Received: (from ernst@localhost) by zaphod.euronet.nl (8.11.6/8.11.6) id g0S8aP833805; Mon, 28 Jan 2002 09:36:25 +0100 (CET) (envelope-from ernst) Message-Id: <200201280836.g0S8aP833805@zaphod.euronet.nl> Content-Type: text/plain; charset="iso-8859-1" From: Ernst de Haan To: Rasputin Subject: Re: tomcat port (PATCH) Date: Mon, 28 Jan 2002 09:36:25 +0100 X-Mailer: KMail [version 1.3.2] Cc: java@FreeBSD.org, dirk@FreeBSD.org, sobomax@FreeBSD.org References: <20011119161722.A56021@shikima.mine.nu> <200111201351.fAKDpBZ24104@zaphod.euronet.nl> <20011121110415.A12931@shikima.mine.nu> In-Reply-To: <20011121110415.A12931@shikima.mine.nu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-java@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Rasputin, Does the new patch do what you would like it to do? Missing anything? Ernst On Wednesday 21 November 2001 12:04, Rasputin wrote: > How does this look for a patch? > It needs a fair bit more work, but at present it: > > 1] makes a dependency on 'javac' rather than an explicit path - > so long as there is a java compiler in your path, it should work. > > 2] makes files/patch-aa correctly set java_home in workers.properties > (dependant on JAVA_HOME; I have a symlink, /usr/java, that I repoint to > /usr/local/jdk1,1,8, /usr/local/linux-jdk1.3.1 or whatever other JDK I'm > using that day) > > 3] Makes tomcat.sh rc script correctly read JAVA_HOME > (overridable by 'make JAVA_HOME=/usr/local/jdk1.1.8' or whatever) > > It also has a couple of *really* clanky post-extract targets in the > Makefile - I don't know a cleaner way of doing it. > > I've tried un/reinstalling it , playing around with a JAVA_HOME > environment variable set to various things, along with explicitly setting > it on the commnad line, and it seems ok - > If this looks OK I'll send-pr it. -- Ernst de Haan EuroNet Internet B.V. "Come to me all who are weary and burdened and I will give you rest" -- Jesus Christ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-java" in the body of the message