From nobody Tue Jun 3 09:01:31 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bBPpX5nTTz5xKMk; Tue, 03 Jun 2025 09:01:40 +0000 (UTC) (envelope-from fuz@fuz.su) Received: from fuz.su (fuz.su [IPv6:2001:41d0:8:e508::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "fuz.su", Issuer "fuz.su" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bBPpX3282z3Mf9; Tue, 03 Jun 2025 09:01:40 +0000 (UTC) (envelope-from fuz@fuz.su) Authentication-Results: mx1.freebsd.org; none Received: from fuz.su (localhost [127.0.0.1]) by fuz.su (8.18.1/8.18.1) with ESMTPS id 55391VRN074745 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 3 Jun 2025 11:01:31 +0200 (CEST) (envelope-from fuz@fuz.su) Received: (from fuz@localhost) by fuz.su (8.18.1/8.18.1/Submit) id 55391VYi074744; Tue, 3 Jun 2025 11:01:31 +0200 (CEST) (envelope-from fuz) Date: Tue, 3 Jun 2025 11:01:31 +0200 From: Robert Clausecker To: Shawn Webb Cc: Robert Clausecker , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e698e4a53773 - main - lib/libmd: disable SHA1 AVX2 kernel Message-ID: References: <202506022333.552NX1uN061534@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4bBPpX3282z3Mf9 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR] Hi Shawn, Am Tue, Jun 03, 2025 at 12:17:26AM +0000 schrieb Shawn Webb: > On Mon, Jun 02, 2025 at 11:33:01PM +0000, Robert Clausecker wrote: > > The branch main has been updated by fuz: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=e698e4a537736f6a7dd9a386e00997d7fb08e83f > > > > commit e698e4a537736f6a7dd9a386e00997d7fb08e83f > > Author: Robert Clausecker > > AuthorDate: 2025-06-02 22:54:32 +0000 > > Commit: Robert Clausecker > > CommitDate: 2025-06-02 23:27:00 +0000 > > > > lib/libmd: disable SHA1 AVX2 kernel > > > > Seems like there is a bug lurking somewhere in the code. This was not > > caught during my testing. Disable the affected kernel for now while I > > figure out what is wrong with it. > > > > To reproduce, run > > > > jot -s '' -b 'a' -n 1000000 | sha1 > > > > This should yield 34aa973cd4c4daa4f61eeb2bdbad27316534016f, but gives > > fe161a71d7941e3d63a9cacadc4f20716a721944 with the broken code. Only the > > amd64/avx2 kernel is affected, the others seem to operate correctly. > > Out of curiosity, how would one best determine whether they're > affected? Would it be a part of the CPU features shown in > /var/run/dmesg.boot? You were affected if you had AVX2 but not SHA in your CPU features in /var/run/dmesg.boot. Thankfully, jrtc27@ seems to have found the transcription errors in the code (see commit 207f3b2b25eaa0f9d32699e664b139e5e40e5450), so if that's all that was wrong with it, I should be able to reenable it soon. Yours, Robert Clausecker -- () ascii ribbon campaign - for an encoding-agnostic world /\ - against html email - against proprietary attachments