From owner-svn-src-head@freebsd.org Tue Sep 26 15:10:00 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 43C19E0E1EE; Tue, 26 Sep 2017 15:10:00 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 1DD0E69BD2; Tue, 26 Sep 2017 15:09:52 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA22956; Tue, 26 Sep 2017 18:09:42 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1dwrUT-000DDF-Rd; Tue, 26 Sep 2017 18:09:41 +0300 Subject: Re: svn commit: r324011 - in head: cddl/contrib/opensolaris/cmd/ztest sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys sys/cddl/contrib/opensolaris/uts/... To: "O. Hartmann" Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201709261104.v8QB480K002320@repo.freebsd.org> <20170926154843.35a405e3@freyja.zeit4.iv.bundesimmobilien.de> From: Andriy Gapon Message-ID: Date: Tue, 26 Sep 2017 18:08:40 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170926154843.35a405e3@freyja.zeit4.iv.bundesimmobilien.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 15:10:00 -0000 On 26/09/2017 16:48, O. Hartmann wrote: > Build world/kernel on r324015 fails due to: > > [...] > ===> lib/libpam/modules/pam_login_access (obj) > --- cddl/lib__L --- > --- zil.o --- > /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c:2333:19: warning: > implicit declaration of function 'cv_timedwait_sbt' is invalid in C99 > [-Wimplicit-function-declaration] int wait_err = cv_timedwait_sbt(&zcw->zcw_cv, > ^ /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c:2335:8: error: > use of undeclared identifier 'C_ABSOLUTE' C_ABSOLUTE); > ^ > --- lib__L --- > --- obj_subdir_lib/libpam/modules/pam_nologin --- > ===> lib/libpam/modules/pam_nologin (obj) > --- cddl/lib__L --- > 1 warning and 1 error generated. Seems like messed up the commit. Not only I managed to somehow commit an older version of what I had in the review request, but I also forget that zil.c is compiled in userland mode as well. A fix is coming shortly. Apologies for the breakage. -- Andriy Gapon