From owner-freebsd-current@FreeBSD.ORG  Mon Jun  2 03:08:55 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2203337B401
	for <freebsd-current@freebsd.org>;
	Mon,  2 Jun 2003 03:08:55 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B8F0F43FA3
	for <freebsd-current@freebsd.org>;
	Mon,  2 Jun 2003 03:08:53 -0700 (PDT)	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id UAA27228;
	Mon, 2 Jun 2003 20:08:44 +1000
Date: Mon, 2 Jun 2003 20:08:43 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Jun Kuriyama <kuriyama@imgsrc.co.jp>
In-Reply-To: <7mvfvpcb8s.wl@black.imgsrc.co.jp>
Message-ID: <20030602194516.Q15091@gamplex.bde.org>
References: <7mvfvpcb8s.wl@black.imgsrc.co.jp>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Current <freebsd-current@freebsd.org>
Subject: Re: Remove absolute symlink in $MAKEOBJDIR
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Jun 2003 10:08:55 -0000

On Mon, 2 Jun 2003, Jun Kuriyama wrote:

> In usual buildworld, we have absolute symbolic links in $MAKEOBJDIR.
> This causes built $MAKEOBJDIR can use to install the world on other
> boxen only if same /usr/src (or etc.) location and same $MAKEOBJDIR.
>
> I'm using this patch for months to avoid this situation.
>
> (1) Copy man pages rather than absolute symlinks.

As marcel pointed out, there are technical reasons for not using cp.
Use cat.

> (2) Use correct dependency in sys/boot/i386/kgzldr.

This is too hackish for me.  Try using the same method as for lib/csu.
I think you nmainly care about "make install" building things.  This is
from longstanding brokenness of installation of man pages which was
cloned to brokenness of installation of FILES.

> Index: sys/boot/i386/kgzldr/Makefile
> ===================================================================
> RCS file: /home/ncvs/src/sys/boot/i386/kgzldr/Makefile,v
> retrieving revision 1.12
> diff -u -r1.12 Makefile
> --- sys/boot/i386/kgzldr/Makefile	30 Sep 2002 20:37:57 -0000	1.12
> +++ sys/boot/i386/kgzldr/Makefile	24 Jan 2003 07:01:52 -0000
> ...
> @@ -15,7 +17,9 @@
>  BOOT_COMCONSOLE_PORT?=	0x3f8
>  AFLAGS+=--defsym SIO_PRT=${BOOT_COMCONSOLE_PORT}
>
> -kgzldr.o: ${OBJS}
> -	${CC} ${LDFLAGS} -o ${.TARGET} ${OBJS}
> +.if target(${PROG})
> +CFLAGS=	${LDFLAGS}
> +LDADD=
> +.endif
>
>  .include <bsd.prog.mk>

Especially-hackish part :-).

Setting LDADD is not needed.

The boot Makefiles already have too many abuses of PROG for non-programs
and/or non-primary targets.

Bruce