From owner-svn-src-head@freebsd.org Mon Jul 23 14:48:09 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FD65104CC5E; Mon, 23 Jul 2018 14:48:09 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E22897F442; Mon, 23 Jul 2018 14:48:08 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-x236.google.com with SMTP id s12-v6so796306ljj.0; Mon, 23 Jul 2018 07:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=L33IQiy4tdLg7Bj2Z6/VLZ0ehRcfgNt+vVyeGbduMp0=; b=PZzEpfPGeoaoItr9Uu2a/CqlB1K5W1QYEXWu6uPgnrT8wK6NCiN2BGD5nj3B3oqqyY kCPHrmnpkF7CgtruY9zXUcip4ca2ACfFnBAn6OZRmQQJglQOE4dgDhUiW/0B+8NwAMhq 4EWvc3yuUYJhE+Ie3dEEePPVQPKLceh+VgghWR0aHDgv62ip2zDa/Hofx+hkyU/zKcu0 Ty8XvW5w9YyocGV55ERgW9fr8Z9mSPMFO8MbvVBsaG9uxNwQI+bQeQz0Kau7nON24Etw Cmgicghp1uL7SMIVmpXDPY7uz3E9tx23S1h6WdHLizlldYnR3hyd+lrgTB4ZqTtjJcaw 87MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=L33IQiy4tdLg7Bj2Z6/VLZ0ehRcfgNt+vVyeGbduMp0=; b=aOJFAnhW6UGydk23rn6iie8ZG9Si5j79upItXzMMRLJMejajL3W52esihEw3oQLN24 GtFdEEyAZ59eufdgKIddoEr63GBOiXn3PlsBDlzLYI1tmoy9diaV4/JWRe/rfQcRztho qfN8O2NoUqkvhVfJ2S/xcZpWavoFb4hYjvpI0L4dIKFmBQ1V1ojuk+STy2Izd2JH0s5b TyIl/IIRGtbCSlvWcBF4UG0yrLCHf8mykZ7mCEX4UsK3o8tSSUSuUhVPJQdIltn0V3ib C7fn32HCeubwUpuB5mjgXE6xd4I9ezCGDGebsBUuHciVEcaeJrCStQoZwVRR4pmUspzc 7XFw== X-Gm-Message-State: AOUpUlFCtwAGD3hFzVCX2tEAsmpUpvrB31ml4yYPbW6ZNMZkXrFeolY/ Cg1W9XrmRnUHAE7CqoDB2YN9DveIFGvvnWHAcoP97Q== X-Google-Smtp-Source: AAOMgpcVb85RXNpbrR6BbR7+F8D5raJH2SEnPT7GdxbcMUKuOKNxaYbCEjqcMjGRWytymRpBUSgMkv9j+0BaMpdc3KU= X-Received: by 2002:a2e:87da:: with SMTP id v26-v6mr9073266ljj.69.1532357286974; Mon, 23 Jul 2018 07:48:06 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 2002:ab3:7851:0:0:0:0:0 with HTTP; Mon, 23 Jul 2018 07:48:06 -0700 (PDT) In-Reply-To: <201807230513.w6N5DM8u049113@slippy.cwsent.com> References: <201807222234.w6MMYKpn030237@repo.freebsd.org> <201807230513.w6N5DM8u049113@slippy.cwsent.com> From: Alan Somers Date: Mon, 23 Jul 2018 08:48:06 -0600 X-Google-Sender-Auth: TB-W8hV5ncaQ4r45APY6R0qC-Yc Message-ID: Subject: Re: svn commit: r336619 - head/lib/libc/gen To: Cy Schubert Cc: Ian Lepore , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 14:48:09 -0000 On Sun, Jul 22, 2018 at 11:13 PM, Cy Schubert wrote: > In message <201807222234.w6MMYKpn030237@repo.freebsd.org>, Ian Lepore > writes: > > Author: ian > > Date: Sun Jul 22 22:34:20 2018 > > New Revision: 336619 > > URL: https://svnweb.freebsd.org/changeset/base/336619 > > > > Log: > > Set the pw_class field to NULL when scanning the non-master passwd > file. > > This avoids a null pointer deref in pw_dup(), which assumes that all > > pointers are either NULL or valid. > > > > Modified: > > head/lib/libc/gen/pw_scan.c > > > > Hi Ian, > > This causes ssh a bit of gas. > > Are you sure, Cy? Judging by the Jenkins output, I think it was the next revision to pw (336625) that broke everything. https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8320/ . -Alan