Date: Mon, 23 Jul 2018 08:48:06 -0600 From: Alan Somers <asomers@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Ian Lepore <ian@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336619 - head/lib/libc/gen Message-ID: <CAOtMX2gef4k-fWALmRBmU%2BsndMLb4brz7AU7JpgTz=Z6DKncOQ@mail.gmail.com> In-Reply-To: <201807230513.w6N5DM8u049113@slippy.cwsent.com> References: <ian@FreeBSD.org> <201807222234.w6MMYKpn030237@repo.freebsd.org> <201807230513.w6N5DM8u049113@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 22, 2018 at 11:13 PM, Cy Schubert <Cy.Schubert@cschubert.com> wrote: > In message <201807222234.w6MMYKpn030237@repo.freebsd.org>, Ian Lepore > writes: > > Author: ian > > Date: Sun Jul 22 22:34:20 2018 > > New Revision: 336619 > > URL: https://svnweb.freebsd.org/changeset/base/336619 > > > > Log: > > Set the pw_class field to NULL when scanning the non-master passwd > file. > > This avoids a null pointer deref in pw_dup(), which assumes that all > > pointers are either NULL or valid. > > > > Modified: > > head/lib/libc/gen/pw_scan.c > > > > Hi Ian, > > This causes ssh a bit of gas. > > Are you sure, Cy? Judging by the Jenkins output, I think it was the next revision to pw (336625) that broke everything. https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8320/ . <https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8320/>; -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2gef4k-fWALmRBmU%2BsndMLb4brz7AU7JpgTz=Z6DKncOQ>