From owner-freebsd-current Fri Jul 16 2:51: 6 1999 Delivered-To: freebsd-current@freebsd.org Received: from not.demophon.com (ns.demophon.com [193.65.70.13]) by hub.freebsd.org (Postfix) with ESMTP id BC82115682 for ; Fri, 16 Jul 1999 02:51:00 -0700 (PDT) (envelope-from will@not.demophon.com) Received: (from will@localhost) by not.demophon.com (8.9.3/8.8.7) id MAA13525; Fri, 16 Jul 1999 12:45:52 +0300 (EEST) (envelope-from will) To: Christopher Sedore Cc: current@freebsd.org Subject: Re: aio and fd patches References: From: Ville-Pertti Keinonen Date: 16 Jul 1999 12:45:51 +0300 In-Reply-To: Christopher Sedore's message of "15 Jul 1999 21:27:57 +0300" Message-ID: <86lnchlygg.fsf@not.demophon.com> Lines: 20 X-Mailer: Gnus v5.5/XEmacs 20.4 - "Emerald" Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Christopher Sedore writes: > You can see my report of issues in kern/12053. I somehow managed to > include a mangled and outdated version of the patch with that report, so > that patch shouldn't be integrated. An updated patch is available at > http://tfeed.maxwell.syr.edu/aio-diff It looks like you're introducing yet another race condition by not ensuring that the file doesn't change from under a socket operation. This can't be fixed the same way my patches fix all (hopefully) of the other races. It might be a good idea to add a 'struct file *' field to the aiocblist structure and forget about the file descriptor number after initially looking it up. This is based on a quick glance, there may be other issues. Note that the style police may want you to consistently add spaces after commas and between binary operators and their operands. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message