From nobody Sun Apr 30 02:54:41 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q89tQ0GtRz48cPN; Sun, 30 Apr 2023 02:54:54 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q89tP2mz8z4Gq1; Sun, 30 Apr 2023 02:54:53 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5286311be47so849002a12.1; Sat, 29 Apr 2023 19:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682823291; x=1685415291; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UpERznqrowvJ4z1hQBXe2PiA73AkM9nWSBZgldG9a+Q=; b=QyYSixHNi3GuvUyiYtGSMAjEdfdkoPfuWvMLqfiIJIaZkYqTYkLegf8iZZMgTmdSxS A6d4kg/BKTo0zAIWluQhFivJkfgb6nxgBg/ZNSy5mseEDF7xSCHrHD9GYu/2HMrljq80 msGUUylYfypOfbF6RmzKcZ8jyQIDREnvXfcqybjDGp6pd/8xz2/s71kWRjkpCoSop5sR 34Q9B8ehrt/98+PLYKxFz52+069tYbZi4Za2w0KDJLWtFEcz+G9sJWQ/fJMr07jpXvqU ZNOyAUbE7B8tfHyAVQ3nYiP5cXLr0aShTqjRPR/rwqYdOCUJHQXrErR1AF+IpOwhiXzY ggTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682823291; x=1685415291; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UpERznqrowvJ4z1hQBXe2PiA73AkM9nWSBZgldG9a+Q=; b=FQKmxHTAkWB9vy4blN9WCaC1mZEROTIqaRYl37tp6oXHRUnqW07Wgf3ioMmeagJY4R OM3hnD2bRJEDErFGCEi3nxkcVL5L6pOa+A8nLmSxmd/L7hWqW+pzwVmwY9XLYrnM6Nzb nxiYuvW7zFBOoVASIT7kC+ZfRectuMUHbK18WfrpuwDyD1aX23MAXIqIXotdG3FqHHmU 8vAQj1K8XHxd2UA7EtUqpa7J++gWjHjmF73exXNmdIUkVA37oPcUFhS3uHHN34l4mOw5 Yu9p14XIE+pJBuL4QvyHg8u8nr5FE0CHSIX7nndRnUUzi0Q71SQV2jGQohasxqHQ0Qh1 MLCg== X-Gm-Message-State: AC+VfDxcaxWtxCw1YtgkTxNqyiXpthPsl2R+/g06vDgZOZsNqKFOMGZO XAE+XRtsGi2jzgJGfqf5DNsUc0HJgLsKKxcnxPOX2LP4dQ== X-Google-Smtp-Source: ACHHUZ7dUbtoRRllptFUu0fFS+yHqFPkHyYK4DUEn9D+swu7erhbPObb1AHdlJ12ZqWXY6wAGMUQIVin6TmKfIs2cy0= X-Received: by 2002:a17:902:d482:b0:19f:8ad5:4331 with SMTP id c2-20020a170902d48200b0019f8ad54331mr12280553plg.38.1682823290612; Sat, 29 Apr 2023 19:54:50 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202304300055.33U0txC4076743@gitrepo.freebsd.org> In-Reply-To: From: Rick Macklem Date: Sat, 29 Apr 2023 19:54:41 -0700 Message-ID: Subject: Re: git: 6995e6b3237e - main - Fix printf format conflict To: Jessica Clarke Cc: Kirk McKusick , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4Q89tP2mz8z4Gq1 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Sat, Apr 29, 2023 at 7:17=E2=80=AFPM Jessica Clarke = wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > > On 30 Apr 2023, at 01:55, Kirk McKusick wrote: > > > > The branch main has been updated by mckusick: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D6995e6b3237e9be9ae6f68af= 13edd3db4b668ab8 > > > > commit 6995e6b3237e9be9ae6f68af13edd3db4b668ab8 > > Author: Kirk McKusick > > AuthorDate: 2023-04-30 00:55:15 +0000 > > Commit: Kirk McKusick > > CommitDate: 2023-04-30 00:55:15 +0000 > > > > Fix printf format conflict > > > > MFC after: 1 week > > --- > > sbin/dumpfs/dumpfs.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sbin/dumpfs/dumpfs.c b/sbin/dumpfs/dumpfs.c > > index 01b475a03fea..743734660e57 100644 > > --- a/sbin/dumpfs/dumpfs.c > > +++ b/sbin/dumpfs/dumpfs.c > > @@ -245,7 +245,7 @@ dumpfs(const char *name, int dosb) > > default: > > goto err; > > } > > - printf("old_cpg\t%d\tsize_cg\t%jd\tCGSIZE\t%jd\n", > > + printf("old_cpg\t%d\tsize_cg\t%d\tCGSIZE\t%d\n", > > afs.fs_old_cpg, sizeof(struct cg), CGSIZE(&afs)); > > size_t is not an int on 64-bit architectures; you want %zu. Since size_t is 32 bits on some arches, don't you need to use %ju and (uintmax_t)sizeof(struct cg)? rick > > Jess > > > printf("sblkno\t%d\tcblkno\t%d\tiblkno\t%d\tdblkno\t%d\n", > > afs.fs_sblkno, afs.fs_cblkno, afs.fs_iblkno, afs.fs_dblkno); > >