From owner-freebsd-amd64@FreeBSD.ORG  Thu May 19 21:30:07 2005
Return-Path: <owner-freebsd-amd64@FreeBSD.ORG>
Delivered-To: freebsd-amd64@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 685D316A4CE
	for <freebsd-amd64@hub.freebsd.org>;
	Thu, 19 May 2005 21:30:07 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 290BA43D67
	for <freebsd-amd64@hub.freebsd.org>;
	Thu, 19 May 2005 21:30:07 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4JLU7fl078286
	for <freebsd-amd64@freefall.freebsd.org>;
	Thu, 19 May 2005 21:30:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4JLU7wg078285;
	Thu, 19 May 2005 21:30:07 GMT
	(envelope-from gnats)
Date: Thu, 19 May 2005 21:30:07 GMT
Message-Id: <200505192130.j4JLU7wg078285@freefall.freebsd.org>
To: freebsd-amd64@FreeBSD.org
From: Adriaan de Groot <groot@kde.org>
Subject: Re: amd64/81279: /usr/games/random returns every line
X-BeenThere: freebsd-amd64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Adriaan de Groot <groot@kde.org>
List-Id: Porting FreeBSD to the AMD64 platform <freebsd-amd64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-amd64>
List-Post: <mailto:freebsd-amd64@freebsd.org>
List-Help: <mailto:freebsd-amd64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 May 2005 21:30:07 -0000

The following reply was made to PR amd64/81279; it has been noted by GNATS.

From: Adriaan de Groot <groot@kde.org>
To: bug-followup@freebsd.org, vivek@khera.org
Cc:  
Subject: Re: amd64/81279: /usr/games/random returns every line
Date: Thu, 19 May 2005 23:26:08 +0200

 Problem is lines like
 
         selected = (int)(denom * random() / LONG_MAX) == 0;
 
 which cause the overflow. Replacing LONG_MAX with INT_MAX here fixes the bug. 
 (The same replacement should probably be done in the other two places that 
 LONG_MAX occurs, since the -e flag is similarly broken.)
 
 -- 
 These are your friends - Adem
     GPG: FEA2 A3FE Adriaan de Groot