From owner-svn-src-projects@freebsd.org Wed Aug 16 13:52:08 2017 Return-Path: <owner-svn-src-projects@freebsd.org> Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AEFADDD0B5 for <svn-src-projects@mailman.ysv.freebsd.org>; Wed, 16 Aug 2017 13:52:08 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 514B184479; Wed, 16 Aug 2017 13:52:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 83BC810AB01; Wed, 16 Aug 2017 09:52:06 -0400 (EDT) From: John Baldwin <jhb@freebsd.org> To: Ngie Cooper <ngie@freebsd.org> Cc: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r322551 - in projects/runtime-coverage/sys/boot: efi/boot1 efi/loader geli i386/boot2 i386/btx/lib i386/gptboot i386/gptzfsboot i386/loader i386/zfsboot mips/beri/loader powerpc/kboot p... Date: Wed, 16 Aug 2017 06:41:24 -0700 Message-ID: <4555783.zflod2nrqZ@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <201708152027.v7FKR89U031476@repo.freebsd.org> References: <201708152027.v7FKR89U031476@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 16 Aug 2017 09:52:06 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" <svn-src-projects.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-projects>, <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/> List-Post: <mailto:svn-src-projects@freebsd.org> List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-projects>, <mailto:svn-src-projects-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 16 Aug 2017 13:52:08 -0000 On Tuesday, August 15, 2017 08:27:08 PM Ngie Cooper wrote: > Author: ngie > Date: Tue Aug 15 20:27:07 2017 > New Revision: 322551 > URL: https://svnweb.freebsd.org/changeset/base/322551 > > Log: > Disable MK_COVERAGE in sys/boot/... > > None of this should be compiled with MK_COVERAGE enabled, and it > fails to compile with it enabled due to unresolved symbols. Would it be a smaller change to make use of Makefile.inc for this? It looks like there is already a sys/boot/Makefile.inc to set other settings that affect all of sys/boot and the various subdirectories of sys/boot all have Makefile.inc's that include ../Makefile.inc. -- John Baldwin