From nobody Thu May 11 09:59:49 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QH6nj2fgjz4B1kv for ; Thu, 11 May 2023 09:59:53 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QH6nh6M6gz3rY8 for ; Thu, 11 May 2023 09:59:52 +0000 (UTC) (envelope-from manu@bidouilliste.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1683799190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vdaJgv7W9GQiyV0yNCH+6EP/JnqPF1y7bJW06O60fdA=; b=AHmMOToiOno9BbVV/dPMIBvaOOJl8YwBEQ4OEVIiheXrIlPvMxK6rqVZXt/8AxDSctiW3j qpYB21m+Eq63wLAD7ctzGI3AgoFJHJBrdahVM+ptO84C/YTI8QIX3qJbFQL4FeCbqVZp6m mcEoZkKBaZVr1zBwvadz5XjBv5KFfwo= Received: from skull.home.blih.net (lfbn-lyo-1-2174-135.w90-66.abo.wanadoo.fr [90.66.97.135]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 78389058 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 11 May 2023 09:59:49 +0000 (UTC) Date: Thu, 11 May 2023 11:59:49 +0200 From: Emmanuel Vadot To: Oleksandr Kryvulia Cc: freebsd-current@freebsd.org Subject: Re: CFT: fwget(8) Message-Id: <20230511115949.43846c83ebe51aba7d4acb14@bidouilliste.com> In-Reply-To: References: <20230511095909.2b4565365e0818fb20b08a8d@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4QH6nh6M6gz3rY8 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Thu, 11 May 2023 12:03:51 +0300 Oleksandr Kryvulia wrote: > 11.05.23 10:59, Emmanuel Vadot ????: > > Hello, > > > > Recently I've adde the fwget(8) utility, see > > https://cgit.freebsd.org/src/commit/?id=3Dd198b8774d2cfb6f140893e1c6236= af9e97d1497 > > > > The goal of this program is to scan the hardware and download the > > needed firmwares, for now it only do that for Intel GPUs and recent AMD > > GPUs (the one supported by amdgpu.ko). > > > > I'd like to know if I handled correctly the mapping between ids on > > Intel and AMD GPUs (for i915kms and amdgpu drm module). > > I'm pretty sure that Intel is correct but I could have messed up some > > AMD ones. Also for some AMD GPUs you need two firmware generations and > > it's hard to know by looking at the code. It would be good to fix any > > bugs/miss-match before 14.0 > > The best way to test if everything works is : > > > > 1/ pkg delete gpu-firmware-\* > > 2/ (optional) pkg install drm-515-kmod/drm-510-kmod (if you had the > > meta package drm-kmod installed it would have been removed in step 1) > > 3/ fwget > > 4/ kldload i915kms/amdgpu > > > > For i915kms just check dmesg for lines saying something like > > "drmn0: successfully loaded firmware image ...", this means that > > everything is correct for your hardware. > > If you see a line like > > "drmn0: could not load firmware image ..." > > please open a PR on bugzilla with dmesg and pciconf -vl attached. > > Note that firmware for i915kms are optional, they only help with power > > management and suspend/resume. > > > > For amdgpu the driver will fail to attach and you will loose the > > display if the firmwares aren't present so you will need to ssh into > > the machine to check for similar lines like i915kms. > > > > Thanks, > > >=20 > Hi, > for me it correctly detects needed package=20 > gpu-firmware-intel-kmod-kabylake, but not install it. > Propposed fix: >=20 > - pkg install -q ${package} > + pkg install -qy ${package} Yes this is on purpose, I didn't wanted to automatically install packages until bugs where solved, but I planned to enable this before 14.0. Cheers, --=20 Emmanuel Vadot