From owner-freebsd-bugs Mon Nov 11 12:30: 6 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E41C937B404 for ; Mon, 11 Nov 2002 12:30:03 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 94CB843E6E for ; Mon, 11 Nov 2002 12:30:01 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id gABKU1x3016907 for ; Mon, 11 Nov 2002 12:30:01 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id gABKU1oj016906; Mon, 11 Nov 2002 12:30:01 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5EA2C37B404 for ; Mon, 11 Nov 2002 12:20:54 -0800 (PST) Received: from sabre.velocet.net (sabre.velocet.net [216.138.209.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id F27FD43E3B for ; Mon, 11 Nov 2002 12:20:53 -0800 (PST) (envelope-from dgilbert@velocet.ca) Received: from trooper.velocet.ca (trooper.velocet.net [216.138.242.2]) by sabre.velocet.net (Postfix) with ESMTP id 1A01B137FD7 for ; Mon, 11 Nov 2002 15:20:48 -0500 (EST) Received: by trooper.velocet.ca (Postfix, from userid 66) id DB71074335; Mon, 11 Nov 2002 15:20:47 -0500 (EST) Received: by canoe.velocet.net (Postfix, from userid 101) id 54D7456766D; Mon, 11 Nov 2002 15:20:45 -0500 (EST) Message-Id: <20021111202045.54D7456766D@canoe.velocet.net> Date: Mon, 11 Nov 2002 15:20:45 -0500 (EST) From: David Gilbert Reply-To: David Gilbert To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/45223: Source Quench packets should not be generated by routers Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 45223 >Category: kern >Synopsis: Source Quench packets should not be generated by routers >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Nov 11 12:30:01 PST 2002 >Closed-Date: >Last-Modified: >Originator: David Gilbert >Release: FreeBSD 4.7-STABLE i386 >Organization: Velocet Communications >Environment: System: FreeBSD canoe.velocet.net 4.7-STABLE FreeBSD 4.7-STABLE #8: Fri Nov 1 18:01:25 EST 2002 dgilbert@canoe.velocet.net:/usr/src/sys/compile/CANOE i386 AFAIK, all FreeBSD is affected by this. >Description: RFC 1812 says that source quench packets should not be generated by routers. Doing so causes DOS amplification. >How-To-Repeat: DOS a FreeBSD router. You can see a 100M full of source quench if your router is powerful enough. >Fix: --- /sys/netinet/ip_input.c Thu Oct 17 08:29:53 2002 +++ ip_input.c Mon Nov 11 15:15:31 2002 @@ -1822,9 +1822,7 @@ break; case ENOBUFS: - type = ICMP_SOURCEQUENCH; - code = 0; - break; + return; case EACCES: /* ipfw denied packet */ m_freem(mcopy); >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message