From owner-freebsd-ports@freebsd.org Sat Feb 4 22:47:46 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2CD0CD157F for ; Sat, 4 Feb 2017 22:47:46 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.com (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8F5A0386; Sat, 4 Feb 2017 22:47:45 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [127.0.0.1] (ip72-204-83-236.fv.ks.cox.net [72.204.83.236]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.com (Postfix) with ESMTP id 5D30243BB9; Sat, 4 Feb 2017 16:45:57 -0600 (CST) Subject: Re: svn commit: r432796 - in head/graphics: rawtherapee rawtherapee-devel To: Gerald Pfeifer , John Marino References: <201701291922.v0TJMlQE038923@repo.freebsd.org> <9c122c71-bc24-0ed4-e671-be49ab06431b@marino.st> Cc: Matthias Andree , ports-committers@freebsd.org, freebsd-ports Reply-To: marino@freebsd.org From: John Marino Message-ID: Date: Sat, 4 Feb 2017 16:47:34 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 170204-0, 02/04/2017), Outbound message X-Antivirus-Status: Clean X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Feb 2017 22:47:46 -0000 On 2/4/2017 16:24, Gerald Pfeifer wrote: > On Fri, 3 Feb 2017, John Marino wrote: >> AFAIK it's not documented, but it's been spoken here quite a few times >> and the result was "try to be nice and if you must use OSVERSION, guard >> it with OPSYS". Anything else is a bug because OSVERSION only makes >> sense with an exact value of OPSYS ("FreeBSD"). > > Would it make sense to add a check to portlint that every condition > (or practically probably line, considering "...\\\n..." as one line) > that has OSVERSION also has OPSYS? When it first came up a few years ago, the topic of portlint came up, but it was decided it wasn't necessary. That's okay because A) it's technically difficult to check all cases and B) I'd almost prefer if portlint emitted a warning that it detected OSVERSION (meaning try to find a platform-generic alternative). Anyway ... I don't discourage that coupling OPSYS with OSVERSION is documented. I think the original idea is that the guideline would "ease in". maybe we're already there because many people are following it on their own now. John --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus