From owner-freebsd-stable@FreeBSD.ORG Thu Dec 11 02:49:43 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C3BD51065670 for ; Thu, 11 Dec 2008 02:49:43 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.225]) by mx1.freebsd.org (Postfix) with ESMTP id 8733F8FC08 for ; Thu, 11 Dec 2008 02:49:43 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so661666rvf.43 for ; Wed, 10 Dec 2008 18:49:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from :to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ZDL0+brdl8NPk/hPUXGSk9wTWrqna+0ABjjaQ36I5X0=; b=nWFfaJIoEtYuqDWsqflgJINXk4P6wYblN/qsSSgZN7vQgh+xaOCbyLTlqq5D3GjC0P kuuopX1TH0R4cJ7qRGftzvStq5OV6kSWabEi7HxliDMYPnmbngWk+oEDWz5Rhh8jp9Dw jsRxsRoKQ9kMi5B9PrbFNR/SKsQQr3GU9JtlQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=dBQt46uEpURgX1ebra5eGC1vd/9H5+SQ6ZqGMoyQsnevbxMWCPo7Ndk0xDKlXVaOnU 82UEgdd1PW8oD3p13D0Y6yeGG8ShtmefAlt4hCKmty/BeU32ZKutxw5ONse2rCx1RzXu ntBHWb3jKnAgDue9VFVy2cUEDivZAMzkoP8Uw= Received: by 10.141.153.17 with SMTP id f17mr1008284rvo.99.1228963782994; Wed, 10 Dec 2008 18:49:42 -0800 (PST) Received: from michelle.cdnetworks.co.kr ([211.53.35.84]) by mx.google.com with ESMTPS id b39sm2176657rvf.0.2008.12.10.18.49.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 10 Dec 2008 18:49:40 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id mBB2nZqj042955 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 11 Dec 2008 11:49:35 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id mBB2nWeN042953; Thu, 11 Dec 2008 11:49:32 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Thu, 11 Dec 2008 11:49:32 +0900 From: Pyun YongHyeon To: Victor Balada Diaz Message-ID: <20081211024932.GC42370@cdnetworks.co.kr> References: <20081209185236.GA1320@alf.bsdes.net> <20081210061226.GC37837@cdnetworks.co.kr> <20081210085934.GB1320@alf.bsdes.net> <20081210102800.GH37837@cdnetworks.co.kr> <20081210113225.GD1320@alf.bsdes.net> <20081210120719.GK37837@cdnetworks.co.kr> <20081210140823.GF1320@alf.bsdes.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081210140823.GF1320@alf.bsdes.net> User-Agent: Mutt/1.4.2.1i Cc: freebsd-stable@freebsd.org, freebsd-amd64@freebsd.org Subject: Re: [ATA] and re(4) stability issues X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2008 02:49:43 -0000 On Wed, Dec 10, 2008 at 03:08:24PM +0100, Victor Balada Diaz wrote: > On Wed, Dec 10, 2008 at 09:07:19PM +0900, Pyun YongHyeon wrote: [...] > > > > > > It seems that your controller supports MSI so you can set a tunable > > > > > > hw.re.msi_disable to 0 to enable MSI. With MSI you can remove > > > > > > interrupt sharing(e.g. add hw.re.msi_disable="0" to > > > > > > /boot/loader.conf file.) However there were several issues on re(4) > > > > > > w.r.t MSI so it was off by default. > > > > > > > > > > This is undocumented and with sysctl -a i can't find the tunable. Is this > > > > > a HEAD feature or it's also in 7.1 -BETA2? Should i add > > > > > > > > Yeah it's an undocmented feature. But most drivers written by me > > > > have similar kobs. Both HEAD and stable/7 including 7.1 BETA2 have > > > > the tunable. > > > > > > I think it could be great if you could document it or at least > > > show it by default when you do sysctl -ad with a small description. > > > > > > > If MSI worked as expected I would have documented it as I did > > in msk(4)/nfe(4)/ale(4)/age(4)/jme(4) etc. > > Using MSI on RealTek does not seem to stable. I tried hard to fix > > that but some users still reported watchdog timeouts. Working > > without documentation and hardware also made it hard to complete > > the work. This was the main reason why MSI was disabled on re(4). > > What do you think about adding a note in the man page telling that > it's experimental and in some cases it could improve the situation > but in others it will give errors? Based on the your testing I have idea how to mitigate the missing Tx completion interrupt. If all goes well re(4) could reliably take advantage of MSI on RealTek controllers. If that miserably fail I would do as you suggested. > > > > I think re(4) in HEAD needs more testing. As you might know RealTek > > produced too many chipsets. :-( > > Ok, i'll use the backported driver as it works better for me :-) > > If i can help you testing any patches i'm more than welcome to do it. > > Thanks a lot for your help Pyun YongHyeon. > You're welcome. -- Regards, Pyun YongHyeon