Date: Thu, 4 Mar 2010 18:34:03 +0530 From: "C. Jayachandran" <c.jayachandran@gmail.com> To: sobomax@freebsd.org Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: newfs failure on -current Message-ID: <98a59be81003040504x6e97fbaeqeb10f8ea7bedb7b9@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
I'm testing this on the mips platform, but I think there is an issue
with change that made sectorsize int64_t, because the ioctl
DIOCGSECTORSIZE used to read sector size seems to take u_int. This
quick change fixes it for me (sample patch - may be whitespace
damaged).
Index: sbin/newfs/newfs.c
===================================================================
--- sbin/newfs/newfs.c (revision 204687)
+++ sbin/newfs/newfs.c (working copy)
@@ -327,9 +327,11 @@
mediasize = st.st_size;
/* set fssize from the partition */
} else {
+ u_int tsize;
if (sectorsize == 0)
- if (ioctl(disk.d_fd, DIOCGSECTORSIZE, §orsize) == -1)
+ if (ioctl(disk.d_fd, DIOCGSECTORSIZE, &tsize) == -1)
sectorsize = 0; /* back out on error for safety */
+ sectorsize = tsize;
if (sectorsize && ioctl(disk.d_fd, DIOCGMEDIASIZE,
&mediasize) != -1)
getfssize(&fssize, special, mediasize / sectorsize, reserved);
}
Regards,
JC.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?98a59be81003040504x6e97fbaeqeb10f8ea7bedb7b9>