From owner-p4-projects@FreeBSD.ORG  Mon Sep 22 16:48:20 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D67DD106567B; Mon, 22 Sep 2008 16:48:20 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9A5261065677
	for <perforce@freebsd.org>; Mon, 22 Sep 2008 16:48:20 +0000 (UTC)
	(envelope-from bz@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 8BA1D8FC27
	for <perforce@freebsd.org>; Mon, 22 Sep 2008 16:48:20 +0000 (UTC)
	(envelope-from bz@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m8MGmK9T022954
	for <perforce@freebsd.org>; Mon, 22 Sep 2008 16:48:20 GMT
	(envelope-from bz@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m8MGmKmX022952
	for perforce@freebsd.org; Mon, 22 Sep 2008 16:48:20 GMT
	(envelope-from bz@freebsd.org)
Date: Mon, 22 Sep 2008 16:48:20 GMT
Message-Id: <200809221648.m8MGmKmX022952@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bz@freebsd.org using -f
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 150275 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Sep 2008 16:48:21 -0000

http://perforce.freebsd.org/chv.cgi?CH=150275

Change 150275 by bz@bz_dumpster on 2008/09/22 16:47:33

	Remove an XXX locking comment.
	Put back the statics.
	Discussed with:		brooks, rwatson

Affected files ...

.. //depot/projects/vimage-commit2/src/sys/net80211/ieee80211_ddb.c#5 edit
.. //depot/projects/vimage-commit2/src/sys/netinet/tcp_sack.c#8 edit

Differences ...

==== //depot/projects/vimage-commit2/src/sys/net80211/ieee80211_ddb.c#5 (text+ko) ====

@@ -194,7 +194,6 @@
 			break;
 		}
 
-	/* XXX to lock or not to lock the vnet list - we are in DDB here? */
 	VNET_FOREACH(vnet_iter) {
 		INIT_VNET_NET(vnet_iter);
 		TAILQ_FOREACH(ifp, &V_ifnet, if_list)

==== //depot/projects/vimage-commit2/src/sys/netinet/tcp_sack.c#8 (text+ko) ====

@@ -130,17 +130,17 @@
 SYSCTL_V_INT(V_NET, vnet_inet, _net_inet_tcp_sack, OID_AUTO, enable,
     CTLFLAG_RW, tcp_do_sack, 0, "Enable/Disable TCP SACK support");
 
-int tcp_sack_maxholes = 128;
+static int tcp_sack_maxholes = 128;
 SYSCTL_V_INT(V_NET, vnet_inet, _net_inet_tcp_sack, OID_AUTO, maxholes,
     CTLFLAG_RW, tcp_sack_maxholes, 0, 
     "Maximum number of TCP SACK holes allowed per connection");
 
-int tcp_sack_globalmaxholes = 65536;
+static int tcp_sack_globalmaxholes = 65536;
 SYSCTL_V_INT(V_NET, vnet_inet, _net_inet_tcp_sack, OID_AUTO, globalmaxholes,
     CTLFLAG_RW, tcp_sack_globalmaxholes, 0, 
     "Global maximum number of TCP SACK holes");
 
-int tcp_sack_globalholes = 0;
+static int tcp_sack_globalholes = 0;
 SYSCTL_V_INT(V_NET, vnet_inet, _net_inet_tcp_sack, OID_AUTO, globalholes,
     CTLFLAG_RD, tcp_sack_globalholes, 0,
     "Global number of TCP SACK holes currently allocated");