From owner-freebsd-bugs@FreeBSD.ORG Sun Aug 22 08:30:27 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A57B216A4CE for ; Sun, 22 Aug 2004 08:30:27 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CFBE43D48 for ; Sun, 22 Aug 2004 08:30:27 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i7M8URI9006109 for ; Sun, 22 Aug 2004 08:30:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i7M8URjc006108; Sun, 22 Aug 2004 08:30:27 GMT (envelope-from gnats) Resent-Date: Sun, 22 Aug 2004 08:30:27 GMT Resent-Message-Id: <200408220830.i7M8URjc006108@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Charlie & Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BC33516A4CE for ; Sun, 22 Aug 2004 08:24:54 +0000 (GMT) Received: from natsmtp00.rzone.de (natsmtp00.rzone.de [81.169.145.165]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2CAE943D31 for ; Sun, 22 Aug 2004 08:24:54 +0000 (GMT) (envelope-from ah@abaton.Haakh.de) Received: from abaton.Haakh.de (p5487A594.dip.t-dialin.net [84.135.165.148]) by post.webmailer.de (8.12.10/8.12.10) with ESMTP id i7M8Oqvd015876 for ; Sun, 22 Aug 2004 10:24:52 +0200 (MEST) Received: from abaton.Haakh.de (localhost [127.0.0.1]) by abaton.Haakh.de (8.13.1/8.13.1) with ESMTP id i7M8OpVn012137 for ; Sun, 22 Aug 2004 10:24:51 +0200 (CEST) (envelope-from ah@abaton.Haakh.de) Received: (from root@localhost) by abaton.Haakh.de (8.13.1/8.13.1/Submit) id i7M8Op4u012136; Sun, 22 Aug 2004 10:24:51 +0200 (CEST) (envelope-from ah) Message-Id: <200408220824.i7M8Op4u012136@abaton.Haakh.de> Date: Sun, 22 Aug 2004 10:24:51 +0200 (CEST) From: Charlie & To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: kern/70815: bug in currently unused function X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Charlie & List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Aug 2004 08:30:27 -0000 >Number: 70815 >Category: kern >Synopsis: bug in currently unused function >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Aug 22 08:30:27 GMT 2004 >Closed-Date: >Last-Modified: >Originator: info [at] haakh.de >Release: FreeBSD 5.2-CURRENT i386 >Organization: Ingenieurbüro Haakh >Environment: System: FreeBSD abaton.Haakh.de 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Wed Aug 18 15:53:28 CEST 2004 root@abaton.Haakh.de:/usr/src/sys/i386/compile/ABATON i386 >Description: Read-error not handeled due to checking the wrong variable >How-To-Repeat: currently unused function >Fix: --- src/sys/boot/common/load.c.orig Fri Dec 19 15:05:54 2003 +++ src/sys/boot/common/load.c Sun Aug 22 10:15:24 2004 @@ -73,7 +73,7 @@ /* Read everything until we know how big it is */ for (;;) { result = read(fd, buf, LOAD_TINYBUF); - if (size == -1) { + if (result == -1) { free(buf, LOAD_TINYBUF); close(fd); return(NULL); >Release-Note: >Audit-Trail: >Unformatted: