From owner-p4-projects@FreeBSD.ORG  Tue Jan 16 22:24:58 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C76F816A4C2; Tue, 16 Jan 2007 22:24:57 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 847AA16A407;
	Tue, 16 Jan 2007 22:24:57 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14])
	by mx1.freebsd.org (Postfix) with ESMTP id 1501E13C442;
	Tue, 16 Jan 2007 22:24:56 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz)
	(8.13.8/8.13.7) with ESMTP id l0GMOtEP011468
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 16 Jan 2007 23:24:55 +0100 (CET)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.8/8.13.3/Submit) id l0GMOtHb011467;
	Tue, 16 Jan 2007 23:24:55 +0100 (CET)
Date: Tue, 16 Jan 2007 23:24:55 +0100
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20070116222455.GA11360@stud.fit.vutbr.cz>
References: <200701141353.l0EDr4Bn085459@repoman.freebsd.org>
	<200701161552.36888.jhb@freebsd.org>
	<20070116221444.GA10264@stud.fit.vutbr.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070116221444.GA10264@stud.fit.vutbr.cz>
User-Agent: Mutt/1.4.2.2i
X-Scanned-By: MIMEDefang 2.57 on 147.229.176.14
Cc: Roman Divacky <rdivacky@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 112893 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2007 22:24:58 -0000

On Tue, Jan 16, 2007 at 11:14:44PM +0100, Divacky Roman wrote:
> On Tue, Jan 16, 2007 at 03:52:36PM -0500, John Baldwin wrote:
> > On Sunday 14 January 2007 08:53, Roman Divacky wrote:
> > > http://perforce.freebsd.org/chv.cgi?CH=112893
> > > 
> > > Change 112893 by rdivacky@rdivacky_witten on 2007/01/14 13:52:42
> > > 
> > > 	Make linux_vfork() actually work. This enables make to work again
> > > 	with 2.6
> > 
> > You should be using RFSTOPPED and starting the new process up after you set 
> > P_PPWAIT before you block to avoid races.
> 
> fork1() for vfork does exactly this... I just copied its behaviour. It also
> seems to me to be more correct but fork1() does it this way.
> 
> can you look at it?

I wrong understood what you said.. ignore the previous mail.

why is it better to set the flag while the p2 process sleeps? the sleeping
affects p1 (parent) process which will sleep anyway - I dont see any race
or something. can you explain please?