From owner-freebsd-testing@FreeBSD.ORG  Sun Mar  9 20:42:59 2014
Return-Path: <owner-freebsd-testing@FreeBSD.ORG>
Delivered-To: freebsd-testing@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 583F9F02
 for <freebsd-testing@freebsd.org>; Sun,  9 Mar 2014 20:42:59 +0000 (UTC)
Received: from mail-qg0-f42.google.com (mail-qg0-f42.google.com
 [209.85.192.42])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1194127F
 for <freebsd-testing@freebsd.org>; Sun,  9 Mar 2014 20:42:58 +0000 (UTC)
Received: by mail-qg0-f42.google.com with SMTP id q107so4927382qgd.1
 for <freebsd-testing@freebsd.org>; Sun, 09 Mar 2014 13:42:51 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc:content-type;
 bh=epqT1ocR2JGjNOqgTFH3bxcr6JnDRZ8hzY9UURout2U=;
 b=BYzzoaMxVEfelMCUmSbMwhJiniyEm0IVkDcAs3oUw2Hk8PkoFFu16IiFQ5htDXGZ9C
 cKrEjCHKKVfRgQuHKifIaYdSl+BNFi377sclL1b9v4sJ7+aMGQo3RAcsRMz53lt01i0Q
 jWgkejsU8In35vccSJEGMXAx+fVDuhtA2aH2NdZUaXE3IL2UtOT0nf6mWGeAjn1A/4lR
 7eiTepyJLAMOoYDL3ItYl6Mm2kmx4MS8ldfUDzLvCTXfhwOjmd1+OuNqQJfnhB0T0Jr9
 Oxs1S2pRll52tfnAcN+5dRGoGxFrjZnjV1ZNrbnso8L2bc4w0zIUmX661uPMYfsuiwTH
 8NKA==
X-Gm-Message-State: ALoCoQkH7luDvzQ4b/fhTkWjIGlcOOtQN94sQF50KhDTtiBBimB2nWc3JCESktpEw7B9GFYmW7t9
X-Received: by 10.224.161.140 with SMTP id r12mr36444384qax.24.1394397771805; 
 Sun, 09 Mar 2014 13:42:51 -0700 (PDT)
MIME-Version: 1.0
Sender: jmmv@meroh.net
Received: by 10.96.83.102 with HTTP; Sun, 9 Mar 2014 13:42:31 -0700 (PDT)
X-Originating-IP: [2620:0:1003:1021:a1b3:b33:a0fa:1de6]
In-Reply-To: <CAGHfRMBvawY9_+YDAeMhVYftW0gNG6ZKZ2i1dL0a0xb-6hMocg@mail.gmail.com>
References: <B5290C1B-F262-479C-8D4F-A5D8B3CE5A52@gmail.com>
 <20140124162759.GB90996@stack.nl>
 <CADyfeQUfxi43A4aXg+du1oGkQAjJFYH1CCXSSoaLKz8nX2hapw@mail.gmail.com>
 <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com>
 <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com>
 <CAFY7cWCBGmZA1GdSNwNPcSeu_vLTHkSs0aMk3sb6sMs2H-Gn8Q@mail.gmail.com>
 <CAGHfRMBvawY9_+YDAeMhVYftW0gNG6ZKZ2i1dL0a0xb-6hMocg@mail.gmail.com>
From: Julio Merino <jmmv@freebsd.org>
Date: Sun, 9 Mar 2014 16:42:31 -0400
X-Google-Sender-Auth: 6ML2oNBC03qbPHgYBAy_DVfC9zk
Message-ID: <CAFY7cWCQKVuvSTNN7issLCHXWcuNPsysk38yLDzcMpkKy5EJ_w@mail.gmail.com>
Subject: Re: [PATCH v2] convert /bin/sh tests over to ATF
To: Garrett Cooper <yaneurabeya@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>,
 Jilles Tjoelker <jilles@stack.nl>
X-BeenThere: freebsd-testing@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>
List-Post: <mailto:freebsd-testing@freebsd.org>
List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, 
 <mailto:freebsd-testing-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Mar 2014 20:42:59 -0000

On Mon, Mar 3, 2014 at 1:40 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote:
> On Sun, Mar 2, 2014 at 1:14 PM, Julio Merino <jmmv@freebsd.org> wrote:
>> * The FILES must continue to be installed. Does this actually work
>> when running your test programs after a "make install"?
>
> Could you please clarify your concern here? I'm not sure I understood
> what you meant.

The tests need to populate /usr/tests/bin/sh/ with the
functional_test.sh driver and all its supporting data files. As I
understand it, your driver code assumes that the data files are
external (i.e. not bundled into the script itself), so those files
must be available from the same location as where the driver lives.
Hence you still need to use FILES to ensure the data files get
installed into /usr/tests/.

... but maybe I'm missing something from your patch; haven't reviewed
it again to double-check this.