Date: Sun, 9 Mar 2014 16:42:31 -0400 From: Julio Merino <jmmv@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Jilles Tjoelker <jilles@stack.nl> Subject: Re: [PATCH v2] convert /bin/sh tests over to ATF Message-ID: <CAFY7cWCQKVuvSTNN7issLCHXWcuNPsysk38yLDzcMpkKy5EJ_w@mail.gmail.com> In-Reply-To: <CAGHfRMBvawY9_%2BYDAeMhVYftW0gNG6ZKZ2i1dL0a0xb-6hMocg@mail.gmail.com> References: <B5290C1B-F262-479C-8D4F-A5D8B3CE5A52@gmail.com> <20140124162759.GB90996@stack.nl> <CADyfeQUfxi43A4aXg%2Bdu1oGkQAjJFYH1CCXSSoaLKz8nX2hapw@mail.gmail.com> <0A68C9FE-6A3A-4DCF-92A9-A506D7581D69@gmail.com> <96373EF8-77EA-4AA6-8422-63881C32E455@gmail.com> <CAFY7cWCBGmZA1GdSNwNPcSeu_vLTHkSs0aMk3sb6sMs2H-Gn8Q@mail.gmail.com> <CAGHfRMBvawY9_%2BYDAeMhVYftW0gNG6ZKZ2i1dL0a0xb-6hMocg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 3, 2014 at 1:40 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote: > On Sun, Mar 2, 2014 at 1:14 PM, Julio Merino <jmmv@freebsd.org> wrote: >> * The FILES must continue to be installed. Does this actually work >> when running your test programs after a "make install"? > > Could you please clarify your concern here? I'm not sure I understood > what you meant. The tests need to populate /usr/tests/bin/sh/ with the functional_test.sh driver and all its supporting data files. As I understand it, your driver code assumes that the data files are external (i.e. not bundled into the script itself), so those files must be available from the same location as where the driver lives. Hence you still need to use FILES to ensure the data files get installed into /usr/tests/. ... but maybe I'm missing something from your patch; haven't reviewed it again to double-check this.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY7cWCQKVuvSTNN7issLCHXWcuNPsysk38yLDzcMpkKy5EJ_w>